Date: Fri, 20 Mar 2020 20:19:56 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: axykon@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Possible typos in the #12.1.1 examples
Message-ID: <20200321001956.GB10066@momjian.us>
References: <158316348159.30450.16075357948244298217@wrigleys.postgresql.org>
 <20200305074523.GX2593@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200305074523.GX2593@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Mar  5, 2020 at 04:45:23PM +0900, Michael Paquier wrote:
> On Mon, Mar 02, 2020 at 03:38:01PM +0000, PG Doc comments form wrote:
> > Seems like here the example missed 'm' as an alias and a dot in the `where`
> > clause:
> > ... messages m
> > ... m.id = 12;
> 
> This query is valid as-is.
> 
> > SELECT m.title || ' ' || m.author || ' ' || m.abstract || ' ' || d.body AS
> > document
> > FROM messages m, docs d
> > WHERE mid = did AND mid = 12;
> > 
> > Possibly, the example missed dots: 
> > ... m.id = d.id AND m.id = 12;
> 
> This one is actually valid as well, as long as both relations don't
> use the same column names, but I can see your point to add the aliases
> to the quals of the WHERE clause to bring more clarity.

Agreed, alias added in all supported branches.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +