Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jFoEu-0004qS-Oj for pgsql-docs@arkaria.postgresql.org; Sun, 22 Mar 2020 00:13:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jFoEt-0002dF-GC for pgsql-docs@arkaria.postgresql.org; Sun, 22 Mar 2020 00:13:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jFoEt-0002d8-88 for pgsql-docs@lists.postgresql.org; Sun, 22 Mar 2020 00:13:15 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFoEq-00067w-C4 for pgsql-docs@lists.postgresql.org; Sun, 22 Mar 2020 00:13:14 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1jFoEo-0004t2-Vk; Sat, 21 Mar 2020 20:13:10 -0400 Date: Sat, 21 Mar 2020 20:13:10 -0400 From: Bruce Momjian To: protodef@gmail.com, pgsql-docs@lists.postgresql.org Subject: Re: optionally schema-qualified for table_name Message-ID: <20200322001310.GA2031@momjian.us> References: <158399268229.5708.13296960177949398026@wrigleys.postgresql.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <158399268229.5708.13296960177949398026@wrigleys.postgresql.org> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Mar 12, 2020 at 05:58:02AM +0000, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-altersequence.html > Description: > > Although I can see that table_name in OWNED BY clause can be optionally > schema-qualified by á…źcarefully reading "The specified table must have the > same owner and be in the same schema as the sequence.", it would be good if > "optionally schema-qualified" is explicitly noted somehow like other pages > such as CREATE TABLE and CREATE VIEW. The same applies to CREATE SEQUENCE > page. I see what you mean. The attached patch fixes this, as well as adjusting the error message. I didn't see any other cases. I thought maybe the schema wasn't mentioned because the table.column defaults to the sequence's schema, but it does not --- you have to specify the column's schema if would not be normally be found via search_path: CREATE SCHEMA zz; SET search_path = zz, public; CREATE TABLE zz.test (x INT); CREATE SEQUENCE zz.ss; ALTER SEQUENCE zz.ss OWNED BY test.x; SET search_path = public, zz; ALTER SEQUENCE zz.ss OWNED BY test.x; SET search_path = public; ALTER SEQUENCE zz.ss OWNED BY test.x; --> ERROR: relation "test" does not exist ALTER SEQUENCE zz.ss OWNED BY zz.test.x; -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription + --RnlQjJ0d97Da+TV1 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="schema.diff" diff --git a/doc/src/sgml/ref/alter_sequence.sgml b/doc/src/sgml/ref/alter_sequence.sgml index bfd20af6d3..b732a68d4e 100644 --- a/doc/src/sgml/ref/alter_sequence.sgml +++ b/doc/src/sgml/ref/alter_sequence.sgml @@ -30,7 +30,7 @@ ALTER SEQUENCE [ IF EXISTS ] name [ START [ WITH ] start ] [ RESTART [ [ WITH ] restart ] ] [ CACHE cache ] [ [ NO ] CYCLE ] - [ OWNED BY { table_name.column_name | NONE } ] + [ OWNED BY { [ schema . ] table_name.column_name | NONE } ] ALTER SEQUENCE [ IF EXISTS ] name OWNER TO { new_owner | CURRENT_USER | SESSION_USER } ALTER SEQUENCE [ IF EXISTS ] name RENAME TO new_name ALTER SEQUENCE [ IF EXISTS ] name SET SCHEMA new_schema @@ -238,7 +238,7 @@ ALTER SEQUENCE [ IF EXISTS ] name S - OWNED BY table_name.column_name + OWNED BY [ schema . ] table_name.column_name OWNED BY NONE diff --git a/doc/src/sgml/ref/create_sequence.sgml b/doc/src/sgml/ref/create_sequence.sgml index e4085804a4..cd72293df9 100644 --- a/doc/src/sgml/ref/create_sequence.sgml +++ b/doc/src/sgml/ref/create_sequence.sgml @@ -26,7 +26,7 @@ CREATE [ TEMPORARY | TEMP ] SEQUENCE [ IF NOT EXISTS ] increment ] [ MINVALUE minvalue | NO MINVALUE ] [ MAXVALUE maxvalue | NO MAXVALUE ] [ START [ WITH ] start ] [ CACHE cache ] [ [ NO ] CYCLE ] - [ OWNED BY { table_name.column_name | NONE } ] + [ OWNED BY { [ schema . ] table_name.column_name | NONE } ] @@ -225,7 +225,7 @@ SELECT * FROM name; - OWNED BY table_name.column_name + OWNED BY [ schema . ] table_name.column_name OWNED BY NONE diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c index 6aab73bfd4..f9750d2cdf 100644 --- a/src/backend/commands/sequence.c +++ b/src/backend/commands/sequence.c @@ -1656,7 +1656,7 @@ process_owned_by(Relation seqrel, List *owned_by, bool for_identity) ereport(ERROR, (errcode(ERRCODE_SYNTAX_ERROR), errmsg("invalid OWNED BY option"), - errhint("Specify OWNED BY table.column or OWNED BY NONE."))); + errhint("Specify OWNED BY [schema.]table.column or OWNED BY NONE."))); tablerel = NULL; attnum = 0; } diff --git a/src/test/regress/expected/sequence.out b/src/test/regress/expected/sequence.out index 8b928b2888..e66059fd75 100644 --- a/src/test/regress/expected/sequence.out +++ b/src/test/regress/expected/sequence.out @@ -19,7 +19,7 @@ ERROR: CACHE (0) must be greater than zero -- OWNED BY errors CREATE SEQUENCE sequence_testx OWNED BY nobody; -- nonsense word ERROR: invalid OWNED BY option -HINT: Specify OWNED BY table.column or OWNED BY NONE. +HINT: Specify OWNED BY [schema.]table.column or OWNED BY NONE. CREATE SEQUENCE sequence_testx OWNED BY pg_class_oid_index.oid; -- not a table ERROR: referenced relation "pg_class_oid_index" is not a table or foreign table CREATE SEQUENCE sequence_testx OWNED BY pg_class.relname; -- not same schema --RnlQjJ0d97Da+TV1--