Date: Tue, 31 Mar 2020 12:58:45 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: =?iso-8859-1?Q?J=FCrgen?= Purtz <juergen@purtz.de>
Cc: Corey Huinker <corey.huinker@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Roger Harkavy <rogerharkavy@gmail.com>,
	pgsql-hackers@postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>,
	Michael Paquier <michael@paquier.xyz>
Subject: Re: Add A Glossary
Message-ID: <20200331175845.GF14618@telsasoft.com>
References: 
 <CADkLM=fwtE-TCU7sRnvaE74z12kOp_A+CdUwMr7aZt39pXbh6A@mail.gmail.com>
 <20200320001122.GA19602@alvherre.pgsql>
 <20200320195841.GA13662@telsasoft.com>
 <64b49f34-eaf6-6de2-e951-0eb8d4afabc2@purtz.de>
 <20200327201200.GV20103@telsasoft.com>
 <ff6028d0-ff04-6d11-c41b-2bddb41777d0@purtz.de>
 <CADkLM=eHCVmL8JnmaW2h+XXLRpKzkLrq6WXMbKB7giJCuS=jXA@mail.gmail.com>
 <84cfa166-89d2-db0c-f5bd-421ca2b2f590@purtz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <84cfa166-89d2-db0c-f5bd-421ca2b2f590@purtz.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
> Please find some minor suggestions in the attachment. They are based on
> Corey's last patch 0001-glossary-v4.patch.

> @@ -220,7 +220,7 @@
>        Record</glossterm>s to the file system and creates a special
>        checkpoint record. This process is initiated when predefined
>        conditions are met, such as a specified amount of time has passed, or
> -      a certain volume of records have been collected.
> +      a certain volume of records has been collected.

I think you're correct in that "volume" is singular.  But I think "collected"
is the wrong world.  I suggested "written".

>       <para>
> -      One of the <acronym>ACID</acronym> properties. This means that concurrently running 
> +      One of the <acronym>ACID</acronym> properties. This means that concurrently running

These could maybe say "required" or "essential" >ACID< properties

>       <para>
> +      In reference to a <glossterm>Table</glossterm>:
>        A <glossterm>Table</glossterm> that can be queried directly,

Maybe: "In reference to a >Relation<: A table which can be queried directly,"

>        table in the collection.
>       </para>
>       <para>
> -      When referring to an <glossterm>Analytic</glossterm>
> -      <glossterm>Function</glossterm>: a partition is a definition
> -      that identifies which neighboring
> +      In reference to a <glossterm>Analytic Function</glossterm>:
s/a/an/

> @@ -1333,7 +1334,8 @@
>      <glossdef>
>       <para>
>        The condition of having no duplicate values in the same
> -      <glossterm>Relation</glossterm>. Often used in the concept of
> +      <glossterm>Column</glossterm> of a <glossterm>Relation</glossterm>.
> +      Often used in the concept of

s/concept/context/, but  I said that before, so maybe it was rejected.

-- 
Justin