Date: Thu, 14 May 2020 09:07:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: daniel@yesql.se, a.lakhin@postgrespro.ru, pgsql-docs@postgresql.org
Subject: Re: Missing comma?
Message-ID: <20200514000738.GA166343@paquier.xyz>
References: <ad1a0badc32658b1bbb07aa312346a1d@postgrespro.ru>
 <5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se>
 <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy"
Content-Disposition: inline
In-Reply-To: <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru>
Precedence: bulk


--gBBFr7Ir9EOA20Yy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 13, 2020 at 05:17:43PM +0300, Marina Polyakova wrote:
> in my opinion it's a little unclear what "or default" means at the end,
> because the comma is used to separate enumeration elements ("d = default
> <...>, n = nothing, f = all columns, i = index <...>") and inside the
> element description ("i = index with indisreplident set, or default").
> Therefore here is an additional patch from me to clarify this place, thanks
> to Alexander Lakhin for help.

Yes, I agree that this last "or default" in the docs does not make
much sense, because we always enforce REPLICA_IDENTITY_NOTHING if
there is no replica identity.

> diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
> index 02ddebae99d98110a8dd290dd4cb0c980adf7984..034a08f80ea4269f131e7e1383ba482fd76d9344 100644
> --- a/doc/src/sgml/catalogs.sgml
> +++ b/doc/src/sgml/catalogs.sgml
> @@ -1936,7 +1936,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
>         <literal>d</literal> = default (primary key, if any),
>         <literal>n</literal> = nothing,
>         <literal>f</literal> = all columns,
> -       <literal>i</literal> = index with <structfield>indisreplident</structfield> set, or default
> +       <literal>i</literal> = index with <structfield>indisreplident</structfield> set (if any)
>        </entry>
>       </row>

And you don't need the ("if any") either here, no?
REPLICA_IDENTITY_INDEX means that we have an index associated with the
replica identity so it seems to me that this last part can just be
removed.
--
Michael

--gBBFr7Ir9EOA20Yy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl68i8oACgkQnvQgOdby
QH2Sjg//aqoed6UBAxTUPNGjSuWSzj5yYc0CsYyu8uuW+xI0YlMb8aSrtY39gTSP
7kIn9iSPKTORiv13sdMZ3Wprz8WaD4WhRHJ0Ry8b6LERGDLY6nxVgrPNVzdoO3vj
LcvsGaEEcTdNbwZ2WK7pXAZlrFXF57/Eoj6wprrjk0UhRvwPEtkKaEpjamPg9iVT
vG0OJ4HqdY78nJtqQ73C+iSbgcQkHqIYQpcbwE7p0boXeCALXcNFSMLg4T4PT0Rc
jBUahupegF06vA1Snku5EmGtI0nWHlQSonhdgogtAUC6vkQ4e/jk53cAv3JyyxgY
Zya47n0ltmrekD+q4YX8oFYxPkeGbFcEDa+mrLzruOzjdKQxxQmfeLD7aEFx8sPr
/XGXY4qhgdkeo5IcdSotbEH2B4EWUtdkUCjoqU2vBcucnf5y1zsmohLofDhc8350
aFqMJlRKA/RflWjKj4AiCPaQ6f548OnA74d+GvJfTql/xZnQkKD4KumuzBgnHeTb
RXurvasMiR1SqdaNMvtZlFG/24EByhjEiFKzOgLSSBF1M+1wQ8v82G3ktDpy4ft/
Ben89jA9AXe9hE2J5qbVilmNyHEcmOJS+RtGMFpFahxc2ipDwPnMWVteWfMLFVgU
a1XHaSQu94HXJkENI6ep4Ub0I8OxVAaWvD5qmqf6wVoWSU/vR7Q=
=VnKh
-----END PGP SIGNATURE-----

--gBBFr7Ir9EOA20Yy--