Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jbuwc-0006SM-97
	for pgsql-docs@arkaria.postgresql.org; Thu, 21 May 2020 23:49:46 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jbuwb-00072B-67
	for pgsql-docs@arkaria.postgresql.org; Thu, 21 May 2020 23:49:45 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jbuwb-00071P-0S
	for pgsql-docs@lists.postgresql.org; Thu, 21 May 2020 23:49:45 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jbuwY-00057O-KG
	for pgsql-docs@postgresql.org; Thu, 21 May 2020 23:49:43 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jbuwX-0008A1-Ir; Thu, 21 May 2020 19:49:41 -0400
Date: Thu, 21 May 2020 19:49:41 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-documentation <pgsql-docs@postgresql.org>
Subject: Re: pgsql: doc: add examples of creative use of unique expression
 indexes
Message-ID: <20200521234941.GB30409@momjian.us>
References: <E1ikvbp-0005jW-E9@gemulon.postgresql.org>
 <2304.1586532634@sss.pgh.pa.us>
 <20200410214821.GC24988@momjian.us>
 <13031.1586560889@sss.pgh.pa.us>
 <20200411001709.GD24988@momjian.us>
 <20200411122532.GE24988@momjian.us>
 <8755.1587414092@sss.pgh.pa.us>
 <20200421003129.GA21241@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200421003129.GA21241@momjian.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

On Mon, Apr 20, 2020 at 08:31:29PM -0400, Bruce Momjian wrote:
> On Mon, Apr 20, 2020 at 04:21:32PM -0400, Tom Lane wrote:
> > [ sorry, I'd lost track of this thread ]
> > 
> > Bruce Momjian <bruce@momjian.us> writes:
> > > I now remember that I wrote the first IS NULL in:
> > >   CREATE UNIQUE INDEX tests_target_one_null ON tests ((target IS NULL)) WHERE target IS NULL;
> > > in hope that if someone is looking for the null value in the column, the
> > > IS NULL would allow the index to be used to find it, while 1 or true
> > > would not.
> > 
> > Well, that's not the case:
> > 
> > regression=# create index tenk1_null_index on tenk1((1)) where ten is null;
> > CREATE INDEX
> > regression=# explain select * from tenk1 where ten is null;
> >                                    QUERY PLAN                                   
> > --------------------------------------------------------------------------------
> >  Index Scan using tenk1_null_index on tenk1  (cost=0.12..8.14 rows=1 width=244)
> > (1 row)
> > 
> > (Maybe it was true at some time in the past, but not any more.)
> > 
> > Also, it complicates the example, and since you didn't explain the
> > reason for the complication, I think it's pretty confusing.
> > 
> > But really I still don't see the need for these additional examples
> > at all.  It's especially weird that what you want to do is have
> > some examples on that page have <example> markup and others not.
> 
> OK, seems like only you and I care about this issue, which I take to
> mean that we should minimize what we are adding here.  What the attached
> patch does is to remove the previous commit, and just add a sentence to
> the last example to mention the ability restrict a column to a single
> NULL.

Patch applied.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +