Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jcAnV-0001Hg-Vr
	for pgsql-docs@arkaria.postgresql.org; Fri, 22 May 2020 16:45:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jcAnT-0001sC-NU
	for pgsql-docs@arkaria.postgresql.org; Fri, 22 May 2020 16:45:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jcAnT-0001s5-Ho
	for pgsql-docs@lists.postgresql.org; Fri, 22 May 2020 16:45:23 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jcAnQ-00086z-OD
	for pgsql-docs@postgresql.org; Fri, 22 May 2020 16:45:23 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jcAnO-0002P0-CA; Fri, 22 May 2020 12:45:18 -0400
Date: Fri, 22 May 2020 12:45:18 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-documentation <pgsql-docs@postgresql.org>
Subject: Re: Adding xreflable
Message-ID: <20200522164518.GG30409@momjian.us>
References: <20200515123923.GB3894@momjian.us>
 <18482.1589549850@sss.pgh.pa.us>
 <20200515134900.GD3894@momjian.us>
 <19807.1589551746@sss.pgh.pa.us>
 <20200515142204.GE3894@momjian.us>
 <22323.1589555218@sss.pgh.pa.us>
 <20200515153034.GG3894@momjian.us>
 <20200515164747.GH3894@momjian.us>
 <8315c0ca-7758-8823-fcb6-f37f9413e6b6@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8315c0ca-7758-8823-fcb6-f37f9413e6b6@2ndquadrant.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

On Fri, May 22, 2020 at 12:09:18PM +0200, Peter Eisentraut wrote:
> On 2020-05-15 18:47, Bruce Momjian wrote:
> > Done.  Thanks for the tips.
> 
> This doesn't seem right.  By adding xreflabels you are changing the
> appearance for all links pointing to the target, not only from the release
> notes.  For example, if you now do
> 
>     see <xref linkend="vacuum-basics"/> and <xref linkend="autovacuum"/>
> 
> which are both sect2s in the same chapter, then you get a rendered text of
> 
>     see Section 24.1.1 and autovacuum
> 
> which is bizarre.
> 
> If you want the link appearance to change only in the release notes, then
> the right approach is to use the <link> tag, as was done before.

Ugh, I see what you mean.  I have read doc/src/sgml/README.links many
times and still get confused.  What you are saying is that if there is
no xreflabel on a target, you can get the chapter/section via <xref> or
specify text via <link>.  But, if there is an xreflabel on the target,
you can't get the chapter/section anymore --- you can only get the
xreflabel via <xref>, or specify text via <link>, right?

I added 13 xreflabels in commits 85af628da5 and 75fcdd2ae2.  What I am
thinking of doing is to look at all references to the id's associated
with those xreflabels and remove the xreflabel if the chapter/section
is required, and if not, convert <link> to <xref> where the link text
matches the xreflabel.  Does that sound like a good plan?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +