Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jl8YW-0006Wy-9r for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jun 2020 10:11:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jl8YU-0002OX-TC for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jun 2020 10:10:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jl8YU-0002OQ-Mi for pgsql-hackers@lists.postgresql.org; Tue, 16 Jun 2020 10:10:58 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jl8YS-00051f-HP for pgsql-hackers@postgresql.org; Tue, 16 Jun 2020 10:10:57 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1jl8YQ-0006Ar-B3; Tue, 16 Jun 2020 06:10:54 -0400 Date: Tue, 16 Jun 2020 06:10:54 -0400 From: Bruce Momjian To: Tom Lane Cc: Joseph Nahmias , PostgreSQL-development Subject: Re: create database with template doesn't copy database ACL Message-ID: <20200616101054.GC31175@momjian.us> References: <159136749445.7029.12571169059565185790@wrigleys.postgresql.org> <20200612212951.GB6813@momjian.us> <20200614072613.GA21852@nahmias.net> <20200615031102.GA12121@momjian.us> <1092722.1592191496@sss.pgh.pa.us> <20200615033934.GB12121@momjian.us> <1095907.1592194495@sss.pgh.pa.us> <20200615141032.GC12121@momjian.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <20200615141032.GC12121@momjian.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 15, 2020 at 10:10:32AM -0400, Bruce Momjian wrote: > On Mon, Jun 15, 2020 at 12:14:55AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Well, I thought we copied everything except things tha can be specified > > > as different in CREATE DATABASE, though I can see why we would not copy > > > them. Should we document this or issue a notice about not copying > > > non-default database attributes? > > > > We do not need a notice for behavior that (a) has stood for twenty years > > or so, and (b) is considerably less broken than any alternative would be. > > If you feel the docs need improvement, have at that. > > Well, I realize it has been this way for a long time, and that no one > else has complained, but there should be a way for people to know what > is being copied from the template and what is not. Do we have a clear > description of what is copied and skipped? We already mentioned that ALTER DATABASE settings are not copied, so the attached patch adds a mention that GRANT-level permissions are not copied either. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee --AhhlLboLdkugWU4S Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="template.diff" diff --git a/doc/src/sgml/ref/create_database.sgml b/doc/src/sgml/ref/create_database.sgml index 504c1b0224..d116b321bc 100644 --- a/doc/src/sgml/ref/create_database.sgml +++ b/doc/src/sgml/ref/create_database.sgml @@ -236,8 +236,8 @@ CREATE DATABASE name Database-level configuration parameters (set via ) are not copied from the template - database. + linkend="sql-alterdatabase"/>) and database-level permissions (set via + ) are not copied from the template database. --AhhlLboLdkugWU4S--