Date: Fri, 21 Aug 2020 18:31:12 -0400
From: Bruce Momjian <bruce@momjian.us>
To: =?iso-8859-1?Q?J=FCrgen?= Purtz <juergen@purtz.de>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: obsolete indexing method "rtree"
Message-ID: <20200821223112.GI13363@momjian.us>
References: <9cda4603-76d0-b063-5dc3-a9a99506340b@purtz.de>
 <2510904.1596636088@sss.pgh.pa.us>
 <e1a6fe18-b4f1-3d4e-8788-ced8c08e086a@purtz.de>
 <CAKFQuwazEREmtP-Z7QXA7yq8bNefSPp_RU54m-oEyHDwAhaOpw@mail.gmail.com>
 <15ec5428-d46a-1725-f38d-44986a977abb@purtz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <15ec5428-d46a-1725-f38d-44986a977abb@purtz.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Aug  7, 2020 at 05:46:45PM +0200, Jürgen Purtz wrote:
> 
> On 06.08.20 10:12, David G. Johnston wrote:
> 
>     On Thu, Aug 6, 2020 at 12:18 AM Jürgen Purtz <juergen@purtz.de> wrote:
> 
> 
>         > Why?
> 
>         Because it can hinder the learning process.
> 
> 
>     FWIW I'd at least fixup comment.sgml to reference a current type.  And
>     while in there might as well add missing examples for the following since
>     we seem to have a goal of providing one example for every syntax (operators
>     get two in order to show NONE, rightarg).
> 
>       EVENT TRIGGER object_name |
>       PUBLICATION object_name |
>       SUBSCRIPTION object_name |
>       ROUTINE routine_name [ ( [ [ argmode ] [ argname ] argtype [, ...] ] ) ]
>     |  
> 
>     Such a "make current" patch that covers this complaint seems reasonable;
>     IOW, why not if you are in there anyway - rtree has some baggage and no
>     particular merit such that a different label would be worse.
> 
>     I don't see the value of removing the backward compatibility hack if it's
>     not bothering the developers.  Whether the documentation should be changed
>     to basically only cover this and nothing more I cannot say without studying
>     said documentation.  I agree with the general motive though.
> 
>     David J.
> 
> 
> Patch with four additional comments and one modified comment attached.

Thanks, patch applied through 11.  We added ROUTINE/PROCEDURE in PG 11,
so I decided not to cherry pick items to be applied prior to that
release.  Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee