Date: Mon, 31 Aug 2020 13:43:35 -0400
From: Bruce Momjian <bruce@momjian.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, 2552891@gmail.com,
	Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Typo in the Section "3.6. Inheritance"
Message-ID: <20200831174335.GH13613@momjian.us>
References: <159586122762.680.1361378513036616007@wrigleys.postgresql.org>
 <20200805211243.GA19840@momjian.us>
 <20200805213656.GB19840@momjian.us>
 <20200806054119.GD16470@paquier.xyz>
 <CAKFQuwY=Bi8T2_D3FoJ0peGqRChp6iEjPXRbR1aPhBfkK8DRdg@mail.gmail.com>
 <20200821233641.GL13363@momjian.us>
 <CAKFQuwYPV+Aw9JjbO5CX-8D5AFbZkwH9zuWpSt53JEEWBi3_Ew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKFQuwYPV+Aw9JjbO5CX-8D5AFbZkwH9zuWpSt53JEEWBi3_Ew@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Aug 21, 2020 at 07:09:31PM -0700, David G. Johnston wrote:
> On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian <bruce@momjian.us> wrote:
> 
>     On Wed, Aug  5, 2020 at 11:29:31PM -0700, David G. Johnston wrote:
> 
>     > Removing "char" from the tutorial is a nice side-effect that we probably
>     want
>     > to do even if we keep "state".
> 
>     I think CHAR(2) is fine because it is always 2 characters.
> 
> 
> You imply "it is always two non-blank characters" though that isn't what CHAR
> (2) means.  Adding CHECK (state ~ '^[A-Z]{2}$') and leaving the type as text
> would be best from a pure model perspective - but this isn't the place to teach
> that and for the same reason char(2) isn't terrible.
> 
> 
>     How is the attached patch, based on your suggestions?
> 
> 
> Works for me.

Patch applied back through 9.5.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee