Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCrWx-0007g2-48 for pgsql-docs@arkaria.postgresql.org; Mon, 31 Aug 2020 21:39:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kCrWt-0003HB-5y for pgsql-docs@arkaria.postgresql.org; Mon, 31 Aug 2020 21:39:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCrTp-0000BU-GL for pgsql-docs@lists.postgresql.org; Mon, 31 Aug 2020 21:36:45 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCrTl-0008Dj-Re for pgsql-docs@postgresql.org; Mon, 31 Aug 2020 21:36:44 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1kCrTk-0003Vq-Ka; Mon, 31 Aug 2020 17:36:40 -0400 Date: Mon, 31 Aug 2020 17:36:40 -0400 From: Bruce Momjian To: Daniel Gustafsson Cc: Alvaro Herrera , PostgreSQL-documentation Subject: Re: ALTER SYSTEM between upgrades Message-ID: <20200831213640.GO13613@momjian.us> References: <20200825185950.GD26852@momjian.us> <2B2E657A-8F23-47D2-B56B-395633DE3AD2@yesql.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2B2E657A-8F23-47D2-B56B-395633DE3AD2@yesql.se> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Aug 26, 2020 at 12:22:25AM +0200, Daniel Gustafsson wrote: > >> One can argue whether those bulletpoints are sufficient for stressing the > >> importance, but it's at least mentioned. There is however no mention of > >> postgresql.auto.conf which clearly isn't helping anyone, so we should fix that. > >> > >> Taking that a step further, maybe we should mention additional config files > >> which could be included via include directives? There are tools out there who > >> avoid changing the users postgresql.conf by injecting an include directive > >> instead; they might've placed the included file alongside postgresql.conf. > > > > I have developed the attached pg_upgrade doc patch to address this. > > LGTM, thanks! Patch applied, -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee