Date: Mon, 14 Sep 2020 14:07:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: btkatsuragiyu <btkatsuragiyu@oss.nttdata.com>,
	pgsql-docs@postgresql.org
Subject: Re: Fix the example in the document of file-fdw
Message-ID: <20200914050716.GC2183@paquier.xyz>
References: <0cd5a9ebbec58bb16fd3f6eb20e401d9@oss.nttdata.com>
 <3b42a115-ebc9-d800-f51f-b5bf7a84201b@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG"
Content-Disposition: inline
In-Reply-To: <3b42a115-ebc9-d800-f51f-b5bf7a84201b@oss.nttdata.com>
Precedence: bulk


--XMCwj5IQnwKtuyBG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote:
> On 2020/09/14 11:19, btkatsuragiyu wrote:
>> Although csvlog has the leader_pid field, the document of file-fdw
>> that uses csvlog as an example does not reflect this fact.
>> Concretely, the DDL for table definition does not have the leader_pid fi=
eld.
>=20
> This seems an oversight of commit b8fdee7d0c.

Dammit, I thought that I had all the places for that stuff done.  The
patch looks fine to me.

>> This patch fixes the DDL in the document of file-fdw.
>=20
> Thanks for the patch! LGTM. I will commit it.

Hmm.  Instead of keeping a copy-paste of the same table in both
config.sgml and file-fdw.sgml, why not having only one?  It seems to=20
me that we could just have the file_fdw doc refer to the main
configuration, and it is not difficult to guess how the CREATE TABLE
query needs to be changed to map with foreign table.
--
Michael

--XMCwj5IQnwKtuyBG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl9e+oQACgkQnvQgOdby
QH1QaQ/9FFpdrqY8481JbiGlzC9G9NtgZL65RYlnItmMhmqOIISJNah0aicxchjT
ZDvgIFBmeMkmvmUSg2p2qM3TFW4IYa8zPLolVw5yBR57AGYAAHetp0DuIKEagvo5
59lu+A1IkxX7ZoaILWZN1QmzB8scKU+m3cKRJu78zaZbxPwv4l/SBwzI7RobRKU1
AkEVqYbuJ6ROvuIFKhUHaw0tpWQP3MycJDdnePaOv3XPhTR+CEePcebzaG7WJ8lZ
NTB3BnRvTgIfKMZ/T2obweaC/NaO6udC53MNwVb5PilYtuGuhDfCHdLh67D0ezMX
0jY54F0Nk4JNpoGM41stsO2h0O5ev9T2i54T6klGBOl9YgfOyX5604lHj74V+Fuz
VDUcpRwt/REY0YJYI9GqgXnIsq+kjj0xYmwcFBRucGArWwmuQPE49gSSgC2Zrebz
xZ/tXvpr091Csn88RBPIYxDTd/zOJNOSmD+7VmzLkXF+VId096JCeKcUpIro8U/w
xk42tbvkdNKRh1j7R8Ekf9zaoMvpslNDAzUGmP4zyaL/HfbYDg7KUs/1iTeQwq15
5rWYxQ8dOXmyhI0HixR7Us1P4rrtEaBB6WTdbcDRvcj1GglhlRGeJ8dfs/1mlgre
+OJTlWNy57dqAeOsoRIyvPjtQ/3iN8os3k1YOKbfKBXp5NaQhK4=
=wZvh
-----END PGP SIGNATURE-----

--XMCwj5IQnwKtuyBG--