Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHjLv-0001rR-NW for pgsql-docs@arkaria.postgresql.org; Mon, 14 Sep 2020 07:56:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kHjLu-00058B-LA for pgsql-docs@arkaria.postgresql.org; Mon, 14 Sep 2020 07:56:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHjLs-000584-UE for pgsql-docs@lists.postgresql.org; Mon, 14 Sep 2020 07:56:42 +0000 Received: from [66.111.4.28] (helo=out4-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHjLp-00035K-Nn for pgsql-docs@postgresql.org; Mon, 14 Sep 2020 07:56:39 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 70B005C00A3; Mon, 14 Sep 2020 03:56:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 14 Sep 2020 03:56:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=D7o4m/isN6jpIrigWVdznbrmSIC xqPtlPVHvq2CoYcI=; b=sFuyv0O7iScUKe9BqSdPxcjwDqZ1SwWd+SUYgrIXQaz aLwYVqEGprJPbCMqJgX4eDAHY++ydEdUN3tj1Ghpfz7vJ/QzUVN+5FdMvo1f+eDC K7NcgS7zjpLY/6YwcMP2y9vpGokcDG+Iyv46Uuxmq90HWzchWDQ7RW8yrDohS58N Gp7tmWnRRdgNHOo2XP+5ldyxVZ+kxl721rZMjI0LcExS1vuRK4vnUfzy25qMb5W/ 2Kwz3QZW+cMHOAa09SPk5zmIEUqAqqfoOdBLLZyck1THZPsU9yviVfBcH3GZ6cI5 kXf71PvT9FBo/XSu8iKJyKXpKBz0U+WtRfna1wtQ4Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=D7o4m/ isN6jpIrigWVdznbrmSICxqPtlPVHvq2CoYcI=; b=ggxjcDH/bYUAGHqkB0pmd4 1YN2y0ObMwlgv208NOIvxL+4GbMU4DiP3hsJ5aeeUNwMsLdvLoNSUK/AvU+B8VMa G2TGGzWMLK3fjyo9Yi3yXBktLJ1XPleORkwujsT8qQf8IRdfAjc89BFShR/UIaBO V3Ch9JlF08+TOSn2Cmg3zLGVge5vajciukn/ATTpYAwwCy2zyr01rERZquhQLpY0 McwC8I8v+wNaHN6Mc0/wLiGKOJsRNlgTrTg2k1zvrVIeyS2zbaLxU++YSgvyD8la CwEj9yAdnpE/CHWGzinoVqs9yEhJ8w2cz4MqeE8yD9juY+aQ3KIf4QqcY/04I5Gg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveej heehieevueeigeelteegleejleeiueeiheegvefhnecukfhppeduuddurddutddvrdduke dtrddukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 7FFB43064685; Mon, 14 Sep 2020 03:56:24 -0400 (EDT) Date: Mon, 14 Sep 2020 16:56:21 +0900 From: Michael Paquier To: btkatsuragiyu Cc: Fujii Masao , pgsql-docs@postgresql.org Subject: Re: Fix the example in the document of file-fdw Message-ID: <20200914075621.GD2183@paquier.xyz> References: <0cd5a9ebbec58bb16fd3f6eb20e401d9@oss.nttdata.com> <3b42a115-ebc9-d800-f51f-b5bf7a84201b@oss.nttdata.com> <20200914050716.GC2183@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3Pql8miugIZX0722" Content-Disposition: inline In-Reply-To: X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.28 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --3Pql8miugIZX0722 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 14, 2020 at 04:10:03PM +0900, btkatsuragiyu wrote: > However, I think showing complete DDL including SERVER pglog and OPTIONS > would be helpful > to users who are not familiar with this feature. Yeah, this could be mentioned on the doc page for file_fdw with an extra sentence, but I agree that it is more complex to understand that than a simple copy-paste from the doc itself. -- Michael --3Pql8miugIZX0722 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl9fIiUACgkQnvQgOdby QH3l1A/8CFvXAGv0heDTTqaAy+ddNriiEAP8wfx15IlUtjRr1iXwdoiX9aOJY+pR dXZh0jg2oHCVpfUEoS8+YWN/r2U7uRhDTc5WoxtK4pWXeghDBZjR7JiglxV6LkIW XHSvInPmToYRJdV4UZeeubyAaUnYQYhxePyxiw0P7k4R/SUyXEVyUzXslWlEe106 9VI8HJm4CC8mb/wI1G+EIV+d1rY7COzj3sel49CHswEaCfGQt5/1yW8SGP51/513 2zUQ4UXWiieE37s3PyRZe75coqYEt1Cjj2qIU0WwAvo22A6uTt8GKJV39sskHdjH EHaT8a5ibSAnay/iHXtQH+9XwAJ4H2jMdOB6Xl2hzm/Ocuh3Hgbdy48tuGmdtOqD Yv4cOEN35jLPq57xE+6SCWKXXCMYZSdQxxakO5fC9xSuMCh/PHMREcIy49PswZw5 4xeH+MyfI50zfX51Y56htvmMr0YmmDW9J2VMZZLPrnn35ZDrpOVhYglIYpg18cbk Q5KD7aNhbVRGHi9j9T3NItt+3zHUxWvqzGMzgjMTVXPmyKc7KbVHjFpyfaYIlsWj 7yR5NzvdVVTHvlMnO05TEgOoyddQjES1csAUOT7AKRpDKS4TEraNG9L7onAVkqcH oYTBJ2fMmoy3z3TOO62Lo4D2Tl/k8m+dGOvXbr2QmykHktfQ4Bk= =g6n6 -----END PGP SIGNATURE----- --3Pql8miugIZX0722--