Date: Mon, 5 Oct 2020 16:28:28 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	Guyren Howe <guyren@gmail.com>,
	Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Please provide examples of rows from
Message-ID: <20201005202828.GC4993@momjian.us>
References: <20200904014618.GB13932@momjian.us>
 <CAKFQuwbBDr22KJRyJQRECO_XU6cyouwz3ocn0Tv4JgG4Gm5hMQ@mail.gmail.com>
 <20200920003910.GA22746@momjian.us>
 <798909.1600562993@sss.pgh.pa.us>
 <20200920013846.GC22746@momjian.us>
 <835988.1600613834@sss.pgh.pa.us>
 <878265.1600625640@sss.pgh.pa.us>
 <20200924185511.GC22807@momjian.us>
 <1668963.1600974324@sss.pgh.pa.us>
 <20200924193714.GD22807@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200924193714.GD22807@momjian.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Sep 24, 2020 at 03:37:14PM -0400, Bruce Momjian wrote:
> On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Yes, this is very helpful.  I was afraid the JSON would overwhelm the
> > > example, but this looks good.  I wrote the attached doc patch which I
> > > think improves this.  I plan to apply it to all supported versions.
> > 
> > Couple thoughts:
> > 
> > * Taking the initial ... out of the syntax synopsis is not an improvement.
> > It makes it look like you can only apply AS to the first function of a
> > ROWS FROM.
> 
> Oh, so the dots represent optional non-column_definition function calls.
> I can't think if a cleaner way to show that, so I guess "..." will have
> to do.
> 
> > * I think the ORDER BY adds nothing to the example except complication
> > and confusion.
> 
> I wanted to highlight that the column_definition specifies the data type
> of the column in other parts of the query.
> 
> > * Maybe the other sentence of explanation would read better as
> > 
> > 	json_to_recordset() is instructed to return two columns,
> > 	the first integer and the second text.  The result of
> > 	generate_series() is used directly.
> 
> OK, better.  New patch attached.

Patch applied to all supported versions.  Thanks to Tom for proposing
the example query, and to the original reporter.  :-)

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee