Date: Mon, 5 Oct 2020 16:31:12 -0400
From: Bruce Momjian <bruce@momjian.us>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>,
	R Ransbottom <rirans@comcast.net>,
	Ian Barwick <ian.barwick@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Documentation: 21.5. Default Roles
Message-ID: <20201005203112.GD4993@momjian.us>
References: 
 <CABUevEzrCyxVx2CMCObt76ZuwnTtwskSjZUJcxEFzNaVcFJ5tw@mail.gmail.com>
 <5982a365-a38a-f81a-003c-f72cb4d7f269@postgresql.org>
 <20200206051131.GA20009@momjian.us>
 <41fb663f-96e5-dece-8aba-97d16f395948@postgresql.org>
 <20200409205716.GB26811@momjian.us>
 <eaf0a37d-c92e-3770-b5ec-1ab129dd9185@postgresql.org>
 <20200410034523.GA26824@momjian.us>
 <4490e710-85f7-87a9-74dd-793d27440bed@postgresql.org>
 <CABUevEwYMVbqMi7fe7n40PeFtj0meNjpP4rx=HwJO8Ef8kj75g@mail.gmail.com>
 <40cafc51-1235-ee8a-dd24-075618361c50@postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <40cafc51-1235-ee8a-dd24-075618361c50@postgresql.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Apr 28, 2020 at 04:02:25PM -0400, Jonathan Katz wrote:
> On 4/28/20 2:19 PM, Magnus Hagander wrote:
> > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz <jkatz@postgresql.org
> > <mailto:jkatz@postgresql.org>> wrote:
> > 
> >     On 4/9/20 11:45 PM, Bruce Momjian wrote:
> >     > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
> >     >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> >     >>> Jonathan, Stephen, with the minor release done, can we focus on
> >     adding
> >     >>> the URL redirect and completing the patch to rename this feature
> >     in the
> >     >>> docs?  Thanks.
> >     >>
> >     >> Yes, I have a prototype for this ready, which I had scrambled
> >     together
> >     >> before the release. I am happy to make it committable in the
> >     coming days.
> >     >
> >     > Thanks.  Once that is done Stephen can apply my patch with his
> >     > additions.
> > 
> >     Please see attached patch for pgweb that allows for the documentation to
> >     be redirected from a page that is removed to a newer page. The way
> >     it works:
> > 
> >     - Checks to see if a page is found. If it is, great!
> >     - Now if a page 404s, we first check to see if there is a forwarding
> >     address, i.e. the new page. If it is, we issue a 301 (permanent
> >     redirecTt).
> >     - If it's still not found, we abort.
> > 
> >     I believe this gives us the desired behavior.
> > 
> >     Thoughts on the patch?
> > 
> > 
> >  Looks good to me. Go for it.
> 
> This is deployed. Ready for the patch in core.

OK, Stephen, I believe you have a more comprehensive patch to make this
change.  When can you complete it?  The above email is from April.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee