Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcciv-0008GH-85 for pgsql-docs@arkaria.postgresql.org; Tue, 10 Nov 2020 23:06:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kcciu-0008Pz-5i for pgsql-docs@arkaria.postgresql.org; Tue, 10 Nov 2020 23:06:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcciu-0008Pr-0C for pgsql-docs@lists.postgresql.org; Tue, 10 Nov 2020 23:06:48 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kccin-0004Mg-7e for pgsql-docs@lists.postgresql.org; Tue, 10 Nov 2020 23:06:46 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1kccii-0003wB-Mm; Tue, 10 Nov 2020 18:06:36 -0500 Date: Tue, 10 Nov 2020 18:06:36 -0500 From: Bruce Momjian To: Tom Lane Cc: Euler Taveira , e.indrupskaya@postgrespro.ru, pgsql-docs@lists.postgresql.org Subject: Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html Message-ID: <20201110230636.GA12947@momjian.us> References: <160379568081.24752.14096853446375954245@wrigleys.postgresql.org> <20201027165424.GO4951@momjian.us> <93414.1604070598@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93414.1604070598@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote: > Euler Taveira writes: > > On Tue, 27 Oct 2020 at 13:54, Bruce Momjian wrote: > >> Uh, in my source tree that is a symlink to > >> src/backend/catalog/pg_type_d.h, but that file is generated by > >> src/backend/catalog/genbki.pl. Does that help you? > > > Shouldn't we replace "are defined in the file" with "are defined in the > > generated file"? That's the only place that mentions *_d.h files. Perhaps > > adding a link to BKI [1] should avoid further questions. > > It'd probably confuse users more, actually. This chapter is aimed at > users of Postgres, not developers. > > >From a user's viewpoint, catalog/pg_type_d.h should look pretty much > like any other installed header. We want to point them at that, not at > pg_type.h, because the latter is painful to include in application code > that doesn't want to buy into the Postgres programming environment > altogether. > > Thinking about it from the perspective of someone dealing with an > installation tree not a source tree, maybe the reference should > be to "server/catalog/pg_type_d.h". That might help disabuse > anyone who's expecting to find it at that path in the git tree. I am confused what the "server/" prefix means in a path name. We currently say: The OIDs of the built-in data types are defined in the file src/include/catalog/pg_type_d.h in the source tree. We could add "compiled": The OIDs of the built-in data types are defined in the file src/include/catalog/pg_type_d.h in the source tree after it is compiled. -------------------- -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee