Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1kcduw-0002ay-TL
	for pgsql-docs@arkaria.postgresql.org; Wed, 11 Nov 2020 00:23:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1kcduv-0008WM-T4
	for pgsql-docs@arkaria.postgresql.org; Wed, 11 Nov 2020 00:23:17 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kcduv-0008WE-NJ
	for pgsql-docs@lists.postgresql.org; Wed, 11 Nov 2020 00:23:17 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kcdut-000565-HY
	for pgsql-docs@lists.postgresql.org; Wed, 11 Nov 2020 00:23:16 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kcduq-000859-Um; Tue, 10 Nov 2020 19:23:12 -0500
Date: Tue, 10 Nov 2020 19:23:12 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>,
	e.indrupskaya@postgrespro.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Missing file is mentioned on page
 https://www.postgresql.org/docs/13/libpq-exec.html
Message-ID: <20201111002312.GE12947@momjian.us>
References: <160379568081.24752.14096853446375954245@wrigleys.postgresql.org>
 <20201027165424.GO4951@momjian.us>
 <CAH503wC7R-gvecEGTZNgv9v04u9Z579xjgTzBJ-JKDiqxvWL_g@mail.gmail.com>
 <93414.1604070598@sss.pgh.pa.us>
 <20201110230636.GA12947@momjian.us>
 <2288763.1605050129@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="45Z9DzgjV8m4Oswq"
Content-Disposition: inline
In-Reply-To: <2288763.1605050129@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk


--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 10, 2020 at 06:15:29PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote:
> >> Thinking about it from the perspective of someone dealing with an
> >> installation tree not a source tree, maybe the reference should
> >> be to "server/catalog/pg_type_d.h".  That might help disabuse
> >> anyone who's expecting to find it at that path in the git tree.
> 
> > I am confused what the "server/" prefix means in a path name.
> 
> That is the path underneath the installation "include" directory
> at which that file will be found.

Yep, it's there.  I thought I checked for an include/catalog install
directory, but obviously not well enough.

> > We currently say:
> 
> > 	The <acronym>OID</acronym>s of the built-in data types are defined in
> > 	the file <filename>src/include/catalog/pg_type_d.h</filename> in the
> > 	source tree.
> 
> Yeah, so also s/source tree/install tree/.

OK, here is a patch that mentions both.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee


--45Z9DzgjV8m4Oswq
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pg_type.diff"

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 9ce32fb39b..73c6a6ea4d 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -3666,8 +3666,8 @@ Oid PQftype(const PGresult *res,
        You can query the system table <literal>pg_type</literal> to
        obtain the names and properties of the various data types. The
        <acronym>OID</acronym>s of the built-in data types are defined
-       in the file <filename>src/include/catalog/pg_type_d.h</filename>
-       in the source tree.
+       in the file <filename>include/catalog/pg_type_d.h</filename>
+       in the compiled source directory and install directory.
       </para>
      </listitem>
     </varlistentry>

--45Z9DzgjV8m4Oswq--