pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedFunctions should be Functions & Procedures
6+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2020-12-23 0eaaeabed7 8985e021df d420ae74a7 docs: document which server-side languages can create procs
* Functions should be Functions & Procedures
@ 2020-11-24 19:15 PG Doc comments form <noreply@postgresql.org>
2020-11-25 18:14 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2020-11-24 19:15 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: dwe@dbi-services.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
Description:
Hi,
since PostgreSQL 11 we have procedures, so referencing to only functions
here seems to ignore that. Shouldn't procedures be mentioned here as well?
Regards
Daniel
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Functions should be Functions & Procedures
2020-11-24 19:15 Functions should be Functions & Procedures PG Doc comments form <noreply@postgresql.org>
@ 2020-11-25 18:14 ` Bruce Momjian <bruce@momjian.us>
2020-11-25 18:23 ` Re: Functions should be Functions & Procedures Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2020-11-25 18:14 UTC (permalink / raw)
To: dwe@dbi-services.com; pgsql-docs@lists.postgresql.org
On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
> Description:
>
> Hi,
>
> since PostgreSQL 11 we have procedures, so referencing to only functions
> here seems to ignore that. Shouldn't procedures be mentioned here as well?
Good point. It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
server-side languages all support procedures. I have developed the
attached patch to mention procedures right at the top. I didn't see a
need to mention function "or procedure" throughout the entire document.
Does this seem sufficient?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:
proc.diff.gz (application/gzip, 1.0K) download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Functions should be Functions & Procedures
2020-11-24 19:15 Functions should be Functions & Procedures PG Doc comments form <noreply@postgresql.org>
2020-11-25 18:14 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
@ 2020-11-25 18:23 ` Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
2020-11-25 18:30 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Westermann (DWE) @ 2020-11-25 18:23 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Hi Bruce,
>On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
>> Description:
>>
>> Hi,
>>
>> since PostgreSQL 11 we have procedures, so referencing to only functions
>> here seems to ignore that. Shouldn't procedures be mentioned here as well?
>Good point. It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
>server-side languages all support procedures. I have developed the
>attached patch to mention procedures right at the top. I didn't see a
>need to mention function "or procedure" throughout the entire document.
>Does this seem sufficient?
Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?
Regards
Daniel
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Functions should be Functions & Procedures
2020-11-24 19:15 Functions should be Functions & Procedures PG Doc comments form <noreply@postgresql.org>
2020-11-25 18:14 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
2020-11-25 18:23 ` Re: Functions should be Functions & Procedures Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
@ 2020-11-25 18:30 ` Bruce Momjian <bruce@momjian.us>
2020-11-25 18:38 ` Re: Functions should be Functions & Procedures Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2020-11-25 18:30 UTC (permalink / raw)
To: Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Wed, Nov 25, 2020 at 06:23:44PM +0000, Daniel Westermann (DWE) wrote:
> Hi Bruce,
>
> >On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:
> >> The following documentation comment has been logged on the website:
> >>
> >> Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
> >> Description:
> >>
> >> Hi,
> >>
> >> since PostgreSQL 11 we have procedures, so referencing to only functions
> >> here seems to ignore that. Shouldn't procedures be mentioned here as well?
>
> >Good point. It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
> >server-side languages all support procedures. I have developed the
> >attached patch to mention procedures right at the top. I didn't see a
> >need to mention function "or procedure" throughout the entire document.
> >Does this seem sufficient?
>
> Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?
It is a gzipp'ed file. I had to use gzip and can't resend it since it
contains the T-C-L URL that is flagged by Spamhaus as spam and causes my
emails to be marked as spam. You can see the patch here:
https://momjian.us/tmp/proc.txt
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Functions should be Functions & Procedures
2020-11-24 19:15 Functions should be Functions & Procedures PG Doc comments form <noreply@postgresql.org>
2020-11-25 18:14 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
2020-11-25 18:23 ` Re: Functions should be Functions & Procedures Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
2020-11-25 18:30 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
@ 2020-11-25 18:38 ` Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
2020-12-23 14:39 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Westermann (DWE) @ 2020-11-25 18:38 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
>On Wed, Nov 25, 2020 at 06:23:44PM +0000, Daniel Westermann (DWE) wrote:
>> Hi Bruce,
>>
>> >On Tue, Nov 24, 2020 at 07:15:29PM +0000, PG Doc comments form wrote:
>> >> The following documentation comment has been logged on the website:
>> >>
>> >> Page: https://www.postgresql.org/docs/13/plpgsql-overview.html
>> >> Description:
>> >>
>> >> Hi,
>> >>
>> >> since PostgreSQL 11 we have procedures, so referencing to only functions
>> >> here seems to ignore that. Shouldn't procedures be mentioned here as well?
>>
>> >Good point. It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
>> >server-side languages all support procedures. I have developed the
>> >attached patch to mention procedures right at the top. I didn't see a
>> >need to mention function "or procedure" throughout the entire document.
>> >Does this seem sufficient?
>>
>> Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?
>It is a gzipp'ed file. I had to use gzip and can't resend it since it
>contains the T-C-L URL that is flagged by Spamhaus as spam and causes my
>emails to be marked as spam. You can see the patch here:
Looks good, thanks.
Regards
Daniel
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Functions should be Functions & Procedures
2020-11-24 19:15 Functions should be Functions & Procedures PG Doc comments form <noreply@postgresql.org>
2020-11-25 18:14 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
2020-11-25 18:23 ` Re: Functions should be Functions & Procedures Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
2020-11-25 18:30 ` Re: Functions should be Functions & Procedures Bruce Momjian <bruce@momjian.us>
2020-11-25 18:38 ` Re: Functions should be Functions & Procedures Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
@ 2020-12-23 14:39 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2020-12-23 14:39 UTC (permalink / raw)
To: Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Wed, Nov 25, 2020 at 06:38:56PM +0000, Daniel Westermann (DWE) wrote:
> >On Wed, Nov 25, 2020 at 06:23:44PM +0000, Daniel Westermann (DWE) wrote:
> >> >Good point. It seems PL/pgSQL, PL/Perl, PL/Python, PL/Tcl, and SPI
> >> >server-side languages all support procedures. I have developed the
> >> >attached patch to mention procedures right at the top. I didn't see a
> >> >need to mention function "or procedure" throughout the entire document.
> >> >Does this seem sufficient?
> >>
> >> Thanks for looking at it. Seems you attachment is corrupt, at least I can not open it. Can you please resend?
>
> >It is a gzipp'ed file. I had to use gzip and can't resend it since it
> >contains the T-C-L URL that is flagged by Spamhaus as spam and causes my
> >emails to be marked as spam. You can see the patch here:
>
> Looks good, thanks.
Thanks, patch applied through 11.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2020-12-23 14:39 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 19:15 Functions should be Functions & Procedures PG Doc comments form <noreply@postgresql.org>
2020-11-25 18:14 ` Bruce Momjian <bruce@momjian.us>
2020-11-25 18:23 ` Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
2020-11-25 18:30 ` Bruce Momjian <bruce@momjian.us>
2020-11-25 18:38 ` Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>
2020-12-23 14:39 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox