public inbox for [email protected]
help / color / mirror / Atom feedMention of PG 14 in docs
6+ messages / 2 participants
[nested] [flat]
* Mention of PG 14 in docs
@ 2021-05-03 23:49 Bruce Momjian <[email protected]>
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Momjian @ 2021-05-03 23:49 UTC (permalink / raw)
To: pgsql-docs; +Cc: Alexander Korotkov <[email protected]>
In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
see this text:
--> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
--> <productname>PostgreSQL</productname> 14, these indexes also support
equality operator (simple comparison operators are not supported).
Note that those indexes may not be as efficient as regular B-tree indexes
for equality operator.
As far as I know, we don't usually mention what version _added_ a
feature like this. I suggest the PG 14 mention be removed.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Mention of PG 14 in docs
@ 2021-05-04 00:10 Bruce Momjian <[email protected]>
parent: Bruce Momjian <[email protected]>
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2021-05-04 00:10 UTC (permalink / raw)
To: pgsql-docs; +Cc: Alexander Korotkov <[email protected]>
On Mon, May 3, 2021 at 07:49:14PM -0400, Bruce Momjian wrote:
> In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
> see this text:
>
> --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
> --> <productname>PostgreSQL</productname> 14, these indexes also support
> equality operator (simple comparison operators are not supported).
> Note that those indexes may not be as efficient as regular B-tree indexes
> for equality operator.
>
> As far as I know, we don't usually mention what version _added_ a
> feature like this. I suggest the PG 14 mention be removed.
Also, what does "simple comparison operators are not supported" mean?
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Mention of PG 14 in docs
@ 2021-05-04 00:20 Bruce Momjian <[email protected]>
parent: Bruce Momjian <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2021-05-04 00:20 UTC (permalink / raw)
To: pgsql-docs; +Cc: Alexander Korotkov <[email protected]>
On Mon, May 3, 2021 at 08:10:24PM -0400, Bruce Momjian wrote:
> On Mon, May 3, 2021 at 07:49:14PM -0400, Bruce Momjian wrote:
> > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
> > see this text:
> >
> > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
> > --> <productname>PostgreSQL</productname> 14, these indexes also support
> > equality operator (simple comparison operators are not supported).
> > Note that those indexes may not be as efficient as regular B-tree indexes
> > for equality operator.
> >
> > As far as I know, we don't usually mention what version _added_ a
> > feature like this. I suggest the PG 14 mention be removed.
>
> Also, what does "simple comparison operators are not supported" mean?
Please ignore this second question since is has been fixed by:
Author: Alexander Korotkov <[email protected]>
2020-11-16 [7adb8feb0] Reword 'simple comparison' => 'inequality' in pgtrgm.sgm
Reword 'simple comparison' => 'inequality' in pgtrgm.sgml
Discussion: https://postgr.es/m/CAMkU%3D1zxfA8_MGBW6sJMj54p8nPoe4bMb5LoG-rMYZVPq4j08Q%40mail.gmail.com
Author: Jeff Janes
The first question about PG 14 is still valid.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Mention of PG 14 in docs
@ 2021-05-04 00:51 Alexander Korotkov <[email protected]>
parent: Bruce Momjian <[email protected]>
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Korotkov @ 2021-05-04 00:51 UTC (permalink / raw)
To: Bruce Momjian <[email protected]>; +Cc: pgsql-docs
Hi, Bruce!
On Tue, May 4, 2021 at 2:49 AM Bruce Momjian <[email protected]> wrote:
> In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
> see this text:
>
> --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
> --> <productname>PostgreSQL</productname> 14, these indexes also support
> equality operator (simple comparison operators are not supported).
> Note that those indexes may not be as efficient as regular B-tree indexes
> for equality operator.
>
> As far as I know, we don't usually mention what version _added_ a
> feature like this. I suggest the PG 14 mention be removed.
I agree with this. Thank you for pointing. Are you OK with the attached patch?
------
Regards,
Alexander Korotkov
Attachments:
[application/octet-stream] pg_trgm_doc_fix.patch (878B, 2-pg_trgm_doc_fix.patch)
download | inline diff:
diff --git a/doc/src/sgml/pgtrgm.sgml b/doc/src/sgml/pgtrgm.sgml
index ca97c7ce00a..7e292822553 100644
--- a/doc/src/sgml/pgtrgm.sgml
+++ b/doc/src/sgml/pgtrgm.sgml
@@ -415,9 +415,8 @@
the purpose of very fast similarity searches. These index types support
the above-described similarity operators, and additionally support
trigram-based index searches for <literal>LIKE</literal>, <literal>ILIKE</literal>,
- <literal>~</literal> and <literal>~*</literal> queries. Beginning in
- <productname>PostgreSQL</productname> 14, these indexes also support
- the equality operator (inequality operators are not supported).
+ <literal>~</literal>, <literal>~*</literal> and <literal>=</literal> queries.
+ Inequality operators are not supported.
Note that those indexes may not be as efficient as regular B-tree indexes
for equality operator.
</para>
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Mention of PG 14 in docs
@ 2021-05-04 00:55 Bruce Momjian <[email protected]>
parent: Alexander Korotkov <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2021-05-04 00:55 UTC (permalink / raw)
To: Alexander Korotkov <[email protected]>; +Cc: pgsql-docs
On Tue, May 4, 2021 at 03:51:51AM +0300, Alexander Korotkov wrote:
> Hi, Bruce!
>
> On Tue, May 4, 2021 at 2:49 AM Bruce Momjian <[email protected]> wrote:
> > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
> > see this text:
> >
> > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
> > --> <productname>PostgreSQL</productname> 14, these indexes also support
> > equality operator (simple comparison operators are not supported).
> > Note that those indexes may not be as efficient as regular B-tree indexes
> > for equality operator.
> >
> > As far as I know, we don't usually mention what version _added_ a
> > feature like this. I suggest the PG 14 mention be removed.
>
> I agree with this. Thank you for pointing. Are you OK with the attached patch?
Yes, sure.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Mention of PG 14 in docs
@ 2021-05-04 01:01 Alexander Korotkov <[email protected]>
parent: Bruce Momjian <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Korotkov @ 2021-05-04 01:01 UTC (permalink / raw)
To: Bruce Momjian <[email protected]>; +Cc: pgsql-docs
On Tue, May 4, 2021 at 3:55 AM Bruce Momjian <[email protected]> wrote:
> On Tue, May 4, 2021 at 03:51:51AM +0300, Alexander Korotkov wrote:
> > Hi, Bruce!
> >
> > On Tue, May 4, 2021 at 2:49 AM Bruce Momjian <[email protected]> wrote:
> > > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
> > > see this text:
> > >
> > > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
> > > --> <productname>PostgreSQL</productname> 14, these indexes also support
> > > equality operator (simple comparison operators are not supported).
> > > Note that those indexes may not be as efficient as regular B-tree indexes
> > > for equality operator.
> > >
> > > As far as I know, we don't usually mention what version _added_ a
> > > feature like this. I suggest the PG 14 mention be removed.
> >
> > I agree with this. Thank you for pointing. Are you OK with the attached patch?
>
> Yes, sure.
Perfect, pushed.
------
Regards,
Alexander Korotkov
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-05-04 01:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 23:49 Mention of PG 14 in docs Bruce Momjian <[email protected]>
2021-05-04 00:10 ` Bruce Momjian <[email protected]>
2021-05-04 00:20 ` Bruce Momjian <[email protected]>
2021-05-04 00:51 ` Alexander Korotkov <[email protected]>
2021-05-04 00:55 ` Bruce Momjian <[email protected]>
2021-05-04 01:01 ` Alexander Korotkov <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox