public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Tom Jakubowski <[email protected]>
Cc: Pg Docs <[email protected]>
Subject: Re: Cities name column name inconsistent
Date: Mon, 14 Jun 2021 12:29:09 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwY2-u68DGu3xJOZfiTTHTBqsx-KZ=Yn3ArOZV2_bq=CHQ@mail.gmail.com>
References: <[email protected]>
	<CAKFQuwY2-u68DGu3xJOZfiTTHTBqsx-KZ=Yn3ArOZV2_bq=CHQ@mail.gmail.com>

On Sat, Jun 12, 2021 at 12:48:25PM -0700, David G. Johnston wrote:
> 
> On Sat, Jun 12, 2021, 12:28 PG Doc comments form <[email protected]>
> wrote:
> 
>     The following documentation comment has been logged on the website:
> 
>     Page: https://www.postgresql.org/docs/13/tutorial-fk.html
>     Description:
> 
>     In earlier sections of the tutorial, the cities table had a column called
>     'name'. In this chapter, when creating the revised schema with foreign
>     keys,
>     the same column in the cities is now called 'city'.
> 
> 
> You are correct.  I don't see an urgent need to spend time figuring out
> something different.

I wrote the attached patch to improve this case.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.



Attachments:

  [text/x-diff] cities.diff (818B, 2-cities.diff)
  download | inline diff:
diff --git a/doc/src/sgml/advanced.sgml b/doc/src/sgml/advanced.sgml
index 2d4ab85d45..71ae423f63 100644
--- a/doc/src/sgml/advanced.sgml
+++ b/doc/src/sgml/advanced.sgml
@@ -46,7 +46,7 @@
 
 <programlisting>
 CREATE VIEW myview AS
-    SELECT city, temp_lo, temp_hi, prcp, date, location
+    SELECT name, temp_lo, temp_hi, prcp, date, location
         FROM weather, cities
         WHERE city = name;
 
@@ -101,12 +101,12 @@ SELECT * FROM myview;
 
 <programlisting>
 CREATE TABLE cities (
-        city     varchar(80) primary key,
+        name     varchar(80) primary key,
         location point
 );
 
 CREATE TABLE weather (
-        city      varchar(80) references cities(city),
+        city      varchar(80) references cities(name),
         temp_lo   int,
         temp_hi   int,
         prcp      real,


reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Cities name column name inconsistent
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox