Date: Wed, 21 Jul 2021 14:24:42 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	"Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>,
	"pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
Subject: Re: Link t the souce code
Message-ID: <202107211824.xki5acvkbiv2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="qcu3u6dvqqdfefp7"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <713760.1626891263@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202107211824.xki5acvkbiv2%40alvherre.pgsql>
Precedence: bulk


--qcu3u6dvqqdfefp7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2021-Jul-21, Tom Lane wrote:

> Hm ... actually, now that I read the committed patch, I realize that
> it's effectively recommending that people build their installations
> from the latest commit on master.  That might be what aspiring PG
> hackers want to do, but it's quite unlikely that Joe DBA wants to.
> I think if we're going to recommend pulling the git repo as the
> way to get the sources, we at least ought to recommend a
> "git checkout REL_n_STABLE" step, and point out that this gives
> you branch tip not a released-and-QAed version.  On the whole though,
> I'm having qualms about recommending this in this particular spot,
> rather than back in Appendix I.  Seems like the wrong audience is
> going to be reading this chapter.

Well, we can remove that first paragraph from there and just refer the
reader to the appendix ... something like this, perhaps.

The appendix already has instructions on cloning the repo.  It doesn't
say anything about branches though, but I'm not sure we want our docs to
become a tutorial on Git.  We already link to git-scm.com though that's
not great; it doesn't explain our branch structure for example.  We
could do better.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/

--qcu3u6dvqqdfefp7
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename="nogit.patch"

diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index fddd7d3905..16856f7736 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -354,24 +354,8 @@ su - postgres
   <title>Getting the Source</title>
 
   <para>
-   The version control repository for <productname>PostgreSQL</productname>
-   can be obtained from
-   <ulink url="https://git.postgresql.org/gitweb/?p=postgresql.git;a=summary"></ulink>;
-   this is the recommended way to obtain the
-   <productname>PostgreSQL</productname> source code.
-   You can obtain a clone of the repository by running
-<screen>
-<userinput>git clone https://git.postgresql.org/git/postgresql.git</userinput>
-</screen>
-   This will create a directory <filename>postgresql</filename> under the current
-   directory with the <productname>PostgreSQL</productname> sources.
-   Change into that directory for the rest of the installation procedure.
-   See <xref linkend="git"/> for further information.
-  </para>
-
-  <para>
-   Alternatively, source code for the released versions can be obtained
-   from the download section of our website:
+   The <productname>PostgreSQL</productname> source code for released versions
+   can be obtained from the download section of our website:
    <ulink url="https://www.postgresql.org/ftp/source/"></ulink>.
    Download then
    <filename>postgresql-<replaceable>version</replaceable>.tar.gz</filename>
@@ -385,6 +369,10 @@ su - postgres
    the current directory with the <productname>PostgreSQL</productname> sources.
    Change into that directory for the rest of the installation procedure.
   </para>
+
+  <para>
+   Alternatively, you can use the Git version control system; see
+   <xref linkend="git"> for more information.
  </sect1>
 
  <sect1 id="install-procedure">

--qcu3u6dvqqdfefp7--