Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8DFi-0005Cl-7V for pgsql-docs@arkaria.postgresql.org; Tue, 27 Jul 2021 02:55:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m8DFh-0001J4-6u for pgsql-docs@arkaria.postgresql.org; Tue, 27 Jul 2021 02:55:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8DFh-0001Iw-16 for pgsql-docs@lists.postgresql.org; Tue, 27 Jul 2021 02:55:29 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8DFe-0000Gl-LO for pgsql-docs@lists.postgresql.org; Tue, 27 Jul 2021 02:55:28 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1m8DFd-0003TJ-15; Mon, 26 Jul 2021 22:55:25 -0400 Date: Mon, 26 Jul 2021 22:55:25 -0400 From: Bruce Momjian To: Tom Lane Cc: troy@frericks.us, pgsql-docs@lists.postgresql.org Subject: Re: Manua correction Message-ID: <20210727025525.GC19774@momjian.us> References: <162614304115.701.2392941350859387646@wrigleys.postgresql.org> <20210715213623.GC14027@momjian.us> <3701102.1626405158@sss.pgh.pa.us> <20210719142355.GA12687@momjian.us> <400208.1626793389@sss.pgh.pa.us> <20210720200617.GA27025@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720200617.GA27025@momjian.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jul 20, 2021 at 04:06:17PM -0400, Bruce Momjian wrote: > On Tue, Jul 20, 2021 at 11:03:09AM -0400, Tom Lane wrote: > > The places where you changed "substring(s)" to "substrings" are maybe > > not flat wrong, but I don't think they're improving the text either. > > IIRC, in most of them you get one match if you didn't use the 'g' > > flag, but possibly multiple matches if you did, and the "substring(s)" > > wording is meant to allude to that without taking the space to spell > > it out explicitly. > > I see what you mean --- there can be multiple capture groups, and > multiple match processing if 'g' is used. I think the text using "(s)" > is too complex, so I spelled out the use 'g' and clarified the case of > multiple groups in a single regex. > > Updated patch attached, and I used a larger line context around the > changes to clarify what was being modified. Patch applied back to PG 13 --- before that, the text supplied as much more minimal. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.