Date: Mon, 9 Aug 2021 14:05:50 -0400
From: Bruce Momjian <bruce@momjian.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: ivanmulhin@gmail.com, Pg Docs <pgsql-docs@lists.postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: incorrect information in documentation
Message-ID: <20210809180550.GC14370@momjian.us>
References: <162851358008.709.11763395628268716122@wrigleys.postgresql.org>
 <CAKFQuwbHsQ14v3i4oEwPOmgEBqEFjG4i=WsuOMmP2q82myvdQQ@mail.gmail.com>
 <CAKFQuwYQacXmG9zMcOgbBtGp-1QusGjXQBfMez9GcHpv=AX6SQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKFQuwYQacXmG9zMcOgbBtGp-1QusGjXQBfMez9GcHpv=AX6SQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210809180550.GC14370%40momjian.us>
Precedence: bulk

On Mon, Aug  9, 2021 at 09:20:53AM -0700, David G. Johnston wrote:
> On Mon, Aug 9, 2021 at 9:06 AM David G. Johnston <david.g.johnston@gmail.com>
> wrote:
> 
>     On Mon, Aug 9, 2021 at 8:02 AM PG Doc comments form <noreply@postgresql.org
>     > wrote:
> 
>         Hello, on page
>         https://www.postgresql.org/docs/current/row-estimation-examples.html -
>         there
>         is a example:
>         selectivity = (1 - null_frac1) * (1 - null_frac2) * min(1/
>         num_distinct1,
>         1/num_distinct2)
>                     = (1 - 0) * (1 - 0) / max(10000, 10000)
>                     = 0.0001
>         in the first string  " * min" and in the second " / max"
>         as I understand it isn't correct.
> 
> 
>     Division is just multiplication by the reciprocal so while the presentation
>     here is inconsistent it is correct.  Likewise, the larger a number the
>     smaller its reciprocal, so the change from min to max also works.  
> 
> 
> 
> FWIW this used to be presented with the calculation and formula in sync, but
> the original had a simple typo in the calculation.  When the typo got fixed
> back in December of 2007 [1] the author of the patch simplified the calculation
> at the same time.  I suggest we update the formula line to match the
> calculation presented.

Nice, can you provide a patch please?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.