Date: Wed, 24 Nov 2021 09:50:13 +0900 (JST)
Message-Id: <20211124.095013.1928208020303363469.horikyota.ntt@gmail.com>
To: alvherre@alvh.no-ip.org
Cc: b1000101@pm.me, pgsql-docs@lists.postgresql.org
Subject: Re: max_slot_wal_keep_size unit is not specified
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <202111231421.zybfdpc5pyln@alvherre.pgsql>
References: <163760291192.26193.10801700492025355788@wrigleys.postgresql.org>
	<202111231421.zybfdpc5pyln@alvherre.pgsql>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20211124.095013.1928208020303363469.horikyota.ntt%40gmail.com>
Precedence: bulk

At Tue, 23 Nov 2021 11:21:05 -0300, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote in 
> On 2021-Nov-22, PG Doc comments form wrote:
> 
> > The unit (I assume it's MB) of max_slot_wal_keep_size is not explicitly
> > specified in the docs. If it's intentional then please, disregards, but I've
> > not been able to deduct that from this page alone. Thanks!
> 
> Well, that's embarrasing.  I'll see about fixing it.

(facepalm..)

> It is a size-based unit.  You would typically specify some unit (say,
> MB) together with the number; internally, because the way this works is
> in terms of whole files, it is rounded down to an integer number of WAL
> segments.  If you don't specify a unit, it is taken to be a number of
> megabytes.
> 
> I wonder why did we make it round down rather than up.  Does this mean
> that if you have max_slot_wal_keep_size=8MB and wal segments of 16 MB,
> the slot gets invalidated with more than zero reserved segments?

That rounding behavior is the way we are generally doing on similar
variables. It is based on the behavior of ConvertToXSegs(). So
max_wal_size for example is rounded-up the same way.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center