Feedback-ID: ia2694551:Fastmail
Date: Mon, 27 Jun 2022 10:48:39 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Noboru Saito <noborusai@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>,
	Michael Paquier <michael@paquier.xyz>,
	Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: proposal: convert comments in documents to html comments
Message-ID: <20220627084839.5fuankjxgt6m62vv@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAAM3qnJDsT6y6t7KY=0VCtrG=uQtNuBdhiUk3vor530WbpPsFA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220627084839.5fuankjxgt6m62vv%40alvherre.pgsql>
Precedence: bulk

On 2022-Jun-27, Noboru Saito wrote:

> > I don't have much of a clue about our docbook toolchain, beyond the
> > basics (plus I have no front-end experience). Is anybody else aware of
> > a reasonable approach to making git hashes discoverable from the html
> > release notes?
> 
> If you simply want to display it with a tooltip, the attached patch
> can do that.
> 
> I also attach html and css.
> Please do not expect the quality of the css,
> as it was created for the purpose of checking the operation.

I like the idea of making the commits unobtrusively visible in the
output page.  This proposal looks a good step forward, but I'm sure we
can improve a little bit more.  For example, can we make the SHA1 hash
for each commit be a link to the gitweb page?  (Does this require
pattern matching in the XLST rule?)  Also, when there's more than one
commit in one entry, it'd be better to have them on separate lines
rather than run together in a single line.

Thanks!

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Linux transformó mi computadora, de una `máquina para hacer cosas',
en un aparato realmente entretenido, sobre el cual cada día aprendo
algo nuevo" (Jaime Salinas)