Date: Sat, 23 Jul 2022 11:12:40 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Liam Bowen <liambowen@gmail.com>,
	pgsql-docs@lists.postgresql.org
Subject: Re: gettext instructions for Windows seems wrong
Message-ID: <20220723031240.y5m4rhrcwrwfijjg@jrouhaud>
References: <164246013804.31952.4958087335645367498@wrigleys.postgresql.org>
 <AE6ADA74-7F1A-48BE-8307-3C48574A0439@yesql.se>
 <Ytq1CmkfqXQ35ljC@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ytq1CmkfqXQ35ljC@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220723031240.y5m4rhrcwrwfijjg%40jrouhaud>
Precedence: bulk

Hi,

On Fri, Jul 22, 2022 at 10:32:42AM -0400, Bruce Momjian wrote:
> On Wed, Jan 19, 2022 at 10:24:57AM +0100, Daniel Gustafsson wrote:
> > > On 17 Jan 2022, at 23:55, PG Doc comments form <noreply@postgresql.org> wrote:
> >
> > > The instructions say that I have to edit config.pl (actually, I had to
> > > create it)..
> >
> > I know next to nothing about NLS on Windows, but regardless of doc updates for
> > this I think we should clarify that config.pl may not exist, like how we do for
> > buildenv.pl.
>
> Good point --- I have developed the attached patch to implement this.

+1, I remember I also got confused by it for a minute the first time I tried to
manually build postgres on Windows.

Patch LGTM.