pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedMissing documentation
8+ messages / 4 participants
[nested] [flat]
* Missing documentation
@ 2022-11-03 08:06 PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 8+ messages in thread
From: PG Doc comments form @ 2022-11-03 08:06 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: stefan.badenhorst@mi-c3.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/15/libpq-connect.html
Description:
On this page:
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS
There is a list of keywords that can be specified as part of the connection
string.
Specifying `jit=off` or `jit=on` is functional in practice, but `jit` is
not included in the documentation.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
@ 2022-11-03 13:58 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
0 siblings, 1 reply; 8+ messages in thread
From: Tom Lane @ 2022-11-03 13:58 UTC (permalink / raw)
To: stefan.badenhorst@mi-c3.com; +Cc: pgsql-docs@lists.postgresql.org
PG Doc comments form <noreply@postgresql.org> writes:
> On this page:
> https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS
> There is a list of keywords that can be specified as part of the connection
> string.
> Specifying `jit=off` or `jit=on` is functional in practice, but `jit` is
> not included in the documentation.
Really? Doesn't work for me:
$ psql "host=localhost port=5432 jit=off"
psql: error: invalid connection option "jit"
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-11-03 14:12 ` Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 15:01 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Badenhorst @ 2022-11-03 14:12 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-docs@lists.postgresql.org
This is working:
postgresql://USERNAME:PASSWORD@server
:5432/the_database?sslmode=disable&jit=off
Maybe I was looking at the wrong documentation page?
On Thu, 3 Nov 2022 at 14:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> PG Doc comments form <noreply@postgresql.org> writes:
> > On this page:
> >
> https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS
>
> > There is a list of keywords that can be specified as part of the
> connection
> > string.
> > Specifying `jit=off` or `jit=on` is functional in practice, but `jit` is
> > not included in the documentation.
>
> Really? Doesn't work for me:
>
> $ psql "host=localhost port=5432 jit=off"
> psql: error: invalid connection option "jit"
>
> regards, tom lane
>
--
Email
Disclaimer
This email is
proprietary to MI-C3 and is intended only for the person to whom it is
addressed. It may contain confidential and privileged information. If you
have received this email in error, please notify the sender and delete this
email, which must not be copied, distributed or disclosed to any other
person. Any views or opinions presented are solely those of the author and
do not necessarily represent those of MI-C3. Since this communication was
affected via email, MI-C3 cannot guarantee that it is secure or error-free
as information could be intercepted, corrupted, lost, destroyed, arrive
late or incomplete, or contain viruses. MI-C3 does not accept liability for
any errors or omissions in the contents of this message or for any damage
resulting from the opening of this message should it contain a virus.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
@ 2022-11-03 15:01 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:07 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
0 siblings, 1 reply; 8+ messages in thread
From: Tom Lane @ 2022-11-03 15:01 UTC (permalink / raw)
To: Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>; +Cc: pgsql-docs@lists.postgresql.org
Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com> writes:
> This is working:
> postgresql://USERNAME:PASSWORD@server
> :5432/the_database?sslmode=disable&jit=off
Again, not for me:
$ psql 'postgresql://postgres@localhost:5432/mydb?sslmode=disable&jit=off'
psql: error: invalid URI query parameter: "jit"
I suspect something in your client environment is stripping off the &...
stuff.
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 15:01 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-11-03 17:07 ` Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 17:25 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Badenhorst @ 2022-11-03 17:07 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-docs@lists.postgresql.org
I am using a prometheus exporter:
https://github.com/prometheus-community/postgres_exporter/
Turning JIT off definitely made a big difference to all our environments.
When using JIT it causes OOM on postgres server after a few days. Adding
jit=off resolved the issue.
I have tested this now for several weeks and memory usage stays stable when
jit=off.
You can see the related issue here:
https://github.com/prometheus-community/postgres_exporter/issues/694
On Thu, 3 Nov 2022 at 16:01, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com> writes:
> > This is working:
> > postgresql://USERNAME:PASSWORD@server
> > :5432/the_database?sslmode=disable&jit=off
>
> Again, not for me:
>
> $ psql 'postgresql://postgres@localhost:5432/mydb?sslmode=disable&jit=off'
> psql: error: invalid URI query parameter: "jit"
>
> I suspect something in your client environment is stripping off the &...
> stuff.
>
> regards, tom lane
>
--
Email
Disclaimer
This email is
proprietary to MI-C3 and is intended only for the person to whom it is
addressed. It may contain confidential and privileged information. If you
have received this email in error, please notify the sender and delete this
email, which must not be copied, distributed or disclosed to any other
person. Any views or opinions presented are solely those of the author and
do not necessarily represent those of MI-C3. Since this communication was
affected via email, MI-C3 cannot guarantee that it is secure or error-free
as information could be intercepted, corrupted, lost, destroyed, arrive
late or incomplete, or contain viruses. MI-C3 does not accept liability for
any errors or omissions in the contents of this message or for any damage
resulting from the opening of this message should it contain a virus.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 15:01 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:07 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
@ 2022-11-03 17:25 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:40 ` Re: Missing documentation Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 8+ messages in thread
From: Tom Lane @ 2022-11-03 17:25 UTC (permalink / raw)
To: Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>; +Cc: pgsql-docs@lists.postgresql.org
Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com> writes:
> I am using a prometheus exporter:
> https://github.com/prometheus-community/postgres_exporter/
Hmm, well, maybe prometheus is doing something with that part of the URL.
There's no such behavior in Postgres itself, though.
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 15:01 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:07 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 17:25 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-11-03 17:40 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-03 17:51 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
0 siblings, 1 reply; 8+ messages in thread
From: Alvaro Herrera @ 2022-11-03 17:40 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>; pgsql-docs@lists.postgresql.org
On 2022-Nov-03, Tom Lane wrote:
> Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com> writes:
> > I am using a prometheus exporter:
> > https://github.com/prometheus-community/postgres_exporter/
>
> Hmm, well, maybe prometheus is doing something with that part of the URL.
> There's no such behavior in Postgres itself, though.
Yeah, that part of the connection URI accepts libpq options, not
Postgres-server options. The only way that you can pass options to the
backend is to use "options=-c foo=bar" in the URI, but both the
whitespace and the second equals sign need to be URI-escaped, so you end
up with something like this:
?sslmode=disable&options=-c%20jit%3Doff
This is explained (to some extent) in "34.1.1.2 Connection URIs",
https://www.postgresql.org/docs/current/libpq-connect.html#id-1.7.3.8.3.6
and later "34.1.2 Parameter Key Words" explains that the parameter
"options" is used to pass command-line (!!) options to the server.
Maybe this bit of documentation is not explicit enough; some additional
examples might clarify things.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Missing documentation
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 15:01 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:07 ` Re: Missing documentation Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 17:25 ` Re: Missing documentation Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:40 ` Re: Missing documentation Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-11-03 17:51 ` Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Badenhorst @ 2022-11-03 17:51 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-docs@lists.postgresql.org
Thanks! This helps.
On Thu, Nov 3, 2022, 18:40 Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2022-Nov-03, Tom Lane wrote:
>
> > Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com> writes:
> > > I am using a prometheus exporter:
> > > https://github.com/prometheus-community/postgres_exporter/
> >
> > Hmm, well, maybe prometheus is doing something with that part of the URL.
> > There's no such behavior in Postgres itself, though.
>
> Yeah, that part of the connection URI accepts libpq options, not
> Postgres-server options. The only way that you can pass options to the
> backend is to use "options=-c foo=bar" in the URI, but both the
> whitespace and the second equals sign need to be URI-escaped, so you end
> up with something like this:
>
> ?sslmode=disable&options=-c%20jit%3Doff
>
> This is explained (to some extent) in "34.1.1.2 Connection URIs",
> https://www.postgresql.org/docs/current/libpq-connect.html#id-1.7.3.8.3.6
>
> and later "34.1.2 Parameter Key Words" explains that the parameter
> "options" is used to pass command-line (!!) options to the server.
>
> Maybe this bit of documentation is not explicit enough; some additional
> examples might clarify things.
>
> --
> Álvaro Herrera 48°01'N 7°57'E —
> https://www.EnterpriseDB.com/
>
--
Email
Disclaimer
This email is
proprietary to MI-C3 and is intended only for the person to whom it is
addressed. It may contain confidential and privileged information. If you
have received this email in error, please notify the sender and delete this
email, which must not be copied, distributed or disclosed to any other
person. Any views or opinions presented are solely those of the author and
do not necessarily represent those of MI-C3. Since this communication was
affected via email, MI-C3 cannot guarantee that it is secure or error-free
as information could be intercepted, corrupted, lost, destroyed, arrive
late or incomplete, or contain viruses. MI-C3 does not accept liability for
any errors or omissions in the contents of this message or for any damage
resulting from the opening of this message should it contain a virus.
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2022-11-03 17:51 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 08:06 Missing documentation PG Doc comments form <noreply@postgresql.org>
2022-11-03 13:58 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 14:12 ` Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 15:01 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:07 ` Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
2022-11-03 17:25 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-11-03 17:40 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-03 17:51 ` Stefan Badenhorst <Stefan.Badenhorst@mi-c3.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox