Date: Sat, 13 Apr 2024 08:00:47 -0700
From: Noah Misch <noah@leadboat.com>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	PostgreSQL-documentation <pgsql-docs@postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: CREATE ROLE inheritance details
Message-ID: <20240413150047.50@rfd.leadboat.com>
References: <Zab9GiV63EENDcWG@momjian.us>
 <8e1b78c8ad45febf2e530e1f7508ee01c68bf2ef.camel@cybertec.at>
 <ZagCmb_F0azUtDdn@momjian.us>
 <CAKFQuwY38v5MXfCDqvEqS_XDEaPGjZLvffNBs9Gzc_XsctMMhA@mail.gmail.com>
 <ZbRL0TwcXjwJ7j-q@momjian.us>
 <CAKFQuwYRYyFuC+2giNpNywazjMsRnt4S7AiPrYM9zeNK7m=LBw@mail.gmail.com>
 <Zbhvx4to5lx-pgGe@momjian.us>
 <CAKFQuwYf6jJvS2DBa0=6ysm2hircXGDYvJ87pt+O2dvcXrb6fQ@mail.gmail.com>
 <20240331061642.07@rfd.leadboat.com>
 <CAKFQuwZMnW-LyqtwjHxZsm6Wkg5Jeg4sm8oM3H22NT2h36uHGg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKFQuwZMnW-LyqtwjHxZsm6Wkg5Jeg4sm8oM3H22NT2h36uHGg@mail.gmail.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20240413150047.50%40rfd.leadboat.com>
Precedence: bulk

On Wed, Apr 03, 2024 at 06:11:47PM -0700, David G. Johnston wrote:
> On Sat, Mar 30, 2024 at 11:16 PM Noah Misch <noah@leadboat.com> wrote:
> > On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote:
> > > +   The membership grants created by the
> > > +   <literal>IN ROLE</literal>, <literal>ROLE</literal>, and
> > <literal>ADMIN</literal>
> > > +   clauses have the role executing this command as the grantee.
> >
> > This should be s/grantee/grantor/, right?
> 
> Correct.
> 
> > > +   If unspecified when create a new role membership this defaults to
> > > +   the inheritance attribute of the role being added.
> >
> > Need s/create/creating/.  Missing comma.  While phrase "role being added"
> > isn't wrong, the rest of the paragraph uses "member" and uses "granted
> > role"
> > to refer to the member-of role.  Putting those together:
> >
> >   If unspecified when creating a new role membership, this defaults to the
> >   inheritance attribute of the new member.
> 
> I like that better.

Pushed as 68ba46d.  Thanks for reviewing.