Feedback-ID: ia2694551:Fastmail
Date: Sat, 19 Oct 2024 13:25:40 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: alvaro@datadoghq.com, pgsql-docs@lists.postgresql.org
Subject: Re: ALTER INDEX documentation is incomplete
Message-ID: <202410191125.ikk6d335ngxo@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="updtkvfwtzfuavk7"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <172924785099.698.15236991344616673753@wrigleys.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/202410191125.ikk6d335ngxo%40alvherre.pgsql>
Precedence: bulk


--updtkvfwtzfuavk7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hello Alvaro,

On 2024-Oct-18, PG Doc comments form wrote:

> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/17/sql-alterindex.html
> Description:
> 
> I am trying to find out whether the syntax `ALTER INDEX name ATTACH
> PARTITION index_name` accepts a schema-qualified index_name. However, there
> is no further reference to the index_name variable in the rest of the page.
> I believe this variable should be referenced in the Parameters section.

Hmm, you're right.  It can be schema-qualified btw:

create table datadog (a int) partition by list (a);
-- CREATE TABLE
create index on only datadog (a);
-- CREATE INDEX
create schema test
   create table datadog1 partition of public.datadog for values in (1)
   create index on datadog1 (a);
-- CREATE SCHEMA
alter index datadog_a_idx attach partition test.datadog1_a_idx;
-- ALTER INDEX

How about the attached patch?

Regards

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I dream about dreams about dreams", sang the nightingale
under the pale moon (Sandman)

--updtkvfwtzfuavk7
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename="alterindex.patch"

diff --git a/doc/src/sgml/ref/alter_index.sgml b/doc/src/sgml/ref/alter_index.sgml
index e26efec064..67887dc31e 100644
--- a/doc/src/sgml/ref/alter_index.sgml
+++ b/doc/src/sgml/ref/alter_index.sgml
@@ -87,10 +87,11 @@ ALTER INDEX ALL IN TABLESPACE <replaceable class="parameter">name</replaceable>
    </varlistentry>
 
    <varlistentry>
-    <term><literal>ATTACH PARTITION</literal></term>
+    <term><literal>ATTACH PARTITION <replaceable class="parameter">index_name</replaceable></literal></term>
     <listitem>
      <para>
-      Causes the named index to become attached to the altered index.
+      Causes the possibly schema-qualified named index to become attached
+      to the altered index.
       The named index must be on a partition of the table containing the
       index being altered, and have an equivalent definition.  An attached
       index cannot be dropped by itself, and will automatically be dropped

--updtkvfwtzfuavk7--