Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 14 Nov 2025 12:05:23 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: jian he <jian.universality@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: copy.sgml: add XML ID attributes to <varlistentry> tags.
Message-ID: <202511141101.kiv5idbnwn2b@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxFsPXCwSVR+_vScZ3bysh4-dpE19iVyeta30uNHwnwnSw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202511141101.kiv5idbnwn2b%40alvherre.pgsql>
Precedence: bulk

On 2025-Oct-29, jian he wrote:

> hi.
> 
> similar to what we did in
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5
> 
> I happened to notice COPY.sgml <refsect1> Parameters section is un-linkable.
> The Parameters section in copy.sgml has shorter explanations compared to
> create_table.sgml, but it contains a long list of options.
> 
> So I think making Each parameter linkable would improve readability.

Makes sense.  I have pushed this.  Two minor tweaks: a) I added IDs to
refsect1s as well, because we do that in the other ref pages, and it
seemed out of place to have them in parameters but not for the sections,
and b) I renamed the ones in your patch to use all-lowercase (as well as
dash instead of underscore), as well as added the "-params" marker to
create a sort of hierarchy of the IDs, the way we do in other pages.

Thanks!

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Linux transformó mi computadora, de una `máquina para hacer cosas',
en un aparato realmente entretenido, sobre el cual cada día aprendo
algo nuevo" (Jaime Salinas)