Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 9C268632400 for ; Wed, 4 Aug 2010 13:16:40 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 70611-08 for ; Wed, 4 Aug 2010 16:16:29 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 02D0C632406 for ; Wed, 4 Aug 2010 13:16:28 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id o74GGRCM020528; Wed, 4 Aug 2010 12:16:27 -0400 (EDT) To: Dmitriy Igrishin cc: pgsql-docs@postgresql.org Subject: Re: PQescapeLiteral(), PQescapeIdentifier() documented with invalid signatures. In-reply-to: References: Comments: In-reply-to Dmitriy Igrishin message dated "Wed, 04 Aug 2010 18:35:41 +0400" Date: Wed, 04 Aug 2010 12:16:27 -0400 Message-ID: <20527.1280938587@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201008/3 X-Sequence-Number: 5827 Dmitriy Igrishin writes: > Actual signatures of libpq's functions PQescapeLiteral(), > PQescapeIdentifier() > is > char *PQescapeLiteral(PGconn *conn, const char *str, size_t len) > char *PQescapeIdentifier(PGconn *conn, const char *str, size_t len) > that differs from signatures provided in the documentation here > http://www.postgresql.org/docs/9.0/static/libpq-exec.html#LIBPQ-EXEC-ESCAPE-STRING Wow ... I can understand missing the "const" declarations, but getting the return type wrong is pretty bad :-(. Amazing nobody caught this before. Thanks, will fix! regards, tom lane