Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpNH-00088F-MX for pgsql-hackers@arkaria.postgresql.org; Sun, 21 Feb 2021 14:06:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lDpNE-0003QP-SI for pgsql-hackers@arkaria.postgresql.org; Sun, 21 Feb 2021 14:06:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpNE-0003QI-EU for pgsql-hackers@lists.postgresql.org; Sun, 21 Feb 2021 14:06:12 +0000 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDpN8-0007Bc-3Z for pgsql-hackers@lists.postgresql.org; Sun, 21 Feb 2021 14:06:11 +0000 Received: from ox-appsuite1.xs4all.net ([194.109.29.134]) by smtp-cloud9.xs4all.net with ESMTPSA id DpN5lA1x6rURqDpN5ln1Fb; Sun, 21 Feb 2021 15:06:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1613916364; bh=eZJmUNps6OGIWplTj36Z1VyZAh9C2U8eyvgCnwzBd0k=; h=Date:From:To:Message-ID:Subject:MIME-Version:Content-Type:From: Subject; b=ChzZ3WFz444vOwjXzcWmOKc38cWc/sf3mXhyGEUeO2XCF+f32vcCcqoiGCNphhmWo EDle5WEJdrxCDmEgxnWII8Y1DbqpR/3n9oPtowF3SD3agVpWwfXddIwJ38le8wy4Il t1rlZ2OHAGktMmTtLnWOHFRb4R6BEm2EbuvuA8NUEQd/Z65rG8usYt2f4D4Hq8FmkC L2tamy1mr+JeETMLT/BEPCFo9NMjZfrAWK0W2feT115Oi76+7H1y6/rd9isLhYV3aG Xsm9fyRigmhtVL04vaOtrrYbOsxu8/9HEiM2Zh4Dl+TD886B2xLmXPvjhuAJ/h1mAI /Mj1LaEODIfsQ== Date: Sun, 21 Feb 2021 15:06:03 +0100 (CET) From: er@xs4all.nl To: Vik Fearing , PostgreSQL Hackers Message-ID: <2056725465.229405.1613916363889@webmailclassic.xs4all.nl> In-Reply-To: References: Subject: Re: GROUP BY DISTINCT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev16 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfEoB8YnKo6RHNfYQ39i5Li8TPcpxlOsD5o8H8j5wxYO/HhVRkxyEOhoQTzvAJki7jDtCTTmk5LmDzhCRMAb/i2xnWppN1H3JiE6gYJ/WNb3KId84vQjR po/aupssLPKhUf6LeEQXNdffGon9mdeAwdL4MMgAmLPzcrcQxCb4XRk2TLn1mx6vNoamxX69L5nlDuJBMfaAzn9rhRwKanX6Ey6ODxzEhdzsBgcSkkw0PIm8 nP3tqg5wZsQQ386/8YV8yw== List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > On 2021.02.21. 13:52 Vik Fearing wrote: > > Attached is a patch to implement this for PostgreSQL. > [] The changed line that gets stuffed into sql_features is missing a terminal value (to fill the 'comments' column). This line: '+T434 GROUP BY DISTINCT YES' (A tab at the end will do, I suppose; that's how I fixed the patch locally) Erik Rijkers