From: Tom Lane <tgl@sss.pgh.pa.us>
To: Erwin Brandstetter <brsaweda@gmail.com>
cc: "David G. Johnston" <david.g.johnston@gmail.com>,
        "pgsql-docs@postgresql.org" <pgsql-docs@postgresql.org>
Subject: Re: Failing example for to_number()
In-reply-to: 
 <CAGHENJ45Lt40ab8rjLo-OjxuXoLZduJTaBi5iPk-z259nkFsRQ@mail.gmail.com>
References: 
 <CAGHENJ45ymd=GOCu1vwV9u7GmCR80_5tW0fP9C_gJKbruGMHvQ@mail.gmail.com>
 <CAKFQuwaWwR5P8U3Y8C3FSfXHVeBgkLG1utG0g8vb5jSx_swX5g@mail.gmail.com>
 <CAGHENJ45Lt40ab8rjLo-OjxuXoLZduJTaBi5iPk-z259nkFsRQ@mail.gmail.com>
Comments: In-reply-to Erwin Brandstetter <brsaweda@gmail.com>
	message dated "Mon, 21 Aug 2017 16:55:52 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21766.1503953637.1@sss.pgh.pa.us>
Date: Mon, 28 Aug 2017 16:53:57 -0400
Message-ID: <21767.1503953637@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

Erwin Brandstetter <brsaweda@gmail.com> writes:
> On 21 August 2017 at 16:30, David G. Johnston <david.g.johnston@gmail.com>
> wrote:
>> On Mon, Aug 21, 2017 at 5:36 AM, Erwin Brandstetter <brsaweda@gmail.com>
>> wrote:
>>> The example fails for locales where the comma (',') does not happen to be
>>> the group separator and the dot ('.') is not the decimal point.

>> If one wants to try the example in a language other than in which the
>> example was written they should modify it so that the literal number being
>> parsed in written in conformance to the locale definition for the language
>> you are using.

> I guess there should be some more explanation.

Yeah.  How about adding something like this to the "Usage notes for
numeric formatting" between tables 9-26 and 9-27:

	* The pattern characters S, L, D, and G represent the sign,
	currency symbol, decimal point, and thousands separator characters
	defined by the current locale (see lc_monetary and lc_numeric).
	The pattern characters period and comma represent those exact
	characters, with the meanings of decimal point and thousands
	separator, regardless of locale.

			regards, tom lane


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs