Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaxPT-0000iO-QI for pgsql-docs@arkaria.postgresql.org; Tue, 19 May 2020 08:15:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jaxOw-0002EQ-32 for pgsql-docs@arkaria.postgresql.org; Tue, 19 May 2020 08:15:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaxOv-0002E5-NX for pgsql-docs@lists.postgresql.org; Tue, 19 May 2020 08:15:01 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jaxOs-0001ne-Cs for pgsql-docs@postgresql.org; Tue, 19 May 2020 08:15:00 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id B91AF21C6822; Tue, 19 May 2020 11:14:56 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail.postgrespro.ru (unknown [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 868B921C6821; Tue, 19 May 2020 11:14:56 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1589876096; bh=oCkwrvMBNv/atymjseltJdtGGxlKZV9F5TDYuxZJnfg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=hlHTS3l4VEhtK/9CKuegKOCaZ4UnjZ1vRVxMkkJudQh0hZJhtd6mXa60Hg+5VImeM RhLcbibto7Jr9RI0cSNWXkc1KEysHlZ8T3fN73wud3x2ZOQCFZPdrLgrepDGI4VzUf rReRiKbuEEJUTvdr8cmH0fz6g6fGYF08QZczbHhw= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_6ae03071aa8c3ae40ee501050cf6f62a" Content-Transfer-Encoding: 7bit Date: Tue, 19 May 2020 11:14:56 +0300 From: Marina Polyakova To: Michael Paquier Cc: daniel@yesql.se, a.lakhin@postgrespro.ru, pgsql-docs@postgresql.org Subject: Re: Missing comma? In-Reply-To: <20200519024918.GC11835@paquier.xyz> References: <5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se> <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru> <20200514000738.GA166343@paquier.xyz> <226cae2ef0bf26a59011de38eec9c7f4@postgrespro.ru> <20200515021625.GD2462@paquier.xyz> <37b6de0c81a52af5c6a120cd3341ce28@postgrespro.ru> <20200518061619.GA1830@paquier.xyz> <74011867ff6e9c35ad195d1c3e44ed6c@postgrespro.ru> <20200519024918.GC11835@paquier.xyz> User-Agent: Roundcube Webmail/1.4.0 Message-ID: <221e090c6993607b971a735280074942@postgrespro.ru> X-Sender: m.polyakova@postgrespro.ru Organization: Postgres Professional List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=_6ae03071aa8c3ae40ee501050cf6f62a Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2020-05-19 05:49, Michael Paquier wrote: > On Mon, May 18, 2020 at 10:31:35PM +0300, Marina Polyakova wrote: >> On 2020-05-18 09:16, Michael Paquier wrote: >>> Would you like to send an updated patch? Note that as the release of >>> beta1 is planned for this week, we have a grace period until the >>> version is tagged on HEAD. >> >> The patch is attached, changes to html such as they were discussed. > > Looks good to me. Thanks! Here is a patch with a fixed commit message (primary index => primary key). -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --=_6ae03071aa8c3ae40ee501050cf6f62a Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v2-0001-Fix-the-description-of-the-field-pg_class.relrepl.patch Content-Disposition: attachment; filename=v2-0001-Fix-the-description-of-the-field-pg_class.relrepl.patch; size=1441 RnJvbSAyYTU0ODEwZjRlMGMxYTQ1NmQ5MDZkMjA5MjY4NTU5YWY0NzZjOTM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbmEgUG9seWFrb3ZhIDxtLnBvbHlha292YUBwb3N0Z3Jl c3Byby5ydT4KRGF0ZTogTW9uLCAxOCBNYXkgMjAyMCAyMjoxOTo0NiArMDMwMApTdWJqZWN0OiBb UEFUQ0ggdjJdIEZpeCB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIGZpZWxkIHBnX2NsYXNzLnJlbHJl cGxpZGVudAoKLSBBZGQgYSBjb21tYSBiZXR3ZWVuICJmID0gYWxsIGNvbHVtbnMiIGFuZCAiaSA9 IGluZGV4IHdpdGggLi4uIi4KLSBGaXggdGhlIGRlc2NyaXB0aW9uIG9mIHJlcGxpY2EgaWRlbnRp dHkgaW5kZXggaWYgdGhlIGluZGV4IHVzZWQgZ290IGRyb3BwZWQKICAoaW4gdGhpcyBjYXNlIHdl IGNhbm5vdCB1cGRhdGUgb3IgZGVsZXRlIHJvd3MgZnJvbSB0aGUgdGFibGUgaWYgdGhlIGFjdGlv biBpcwogIHB1Ymxpc2hlZCBldmVuIGlmIHRoZSB0YWJsZSBoYXMgYSBwcmltYXJ5IGtleSkuCi0t LQogZG9jL3NyYy9zZ21sL2NhdGFsb2dzLnNnbWwgfCA2ICsrKystLQogMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3Nn bWwvY2F0YWxvZ3Muc2dtbCBiL2RvYy9zcmMvc2dtbC9jYXRhbG9ncy5zZ21sCmluZGV4IGIxYjA3 N2M5N2YuLjU4YTI1ZThlNjggMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9jYXRhbG9ncy5zZ21s CisrKyBiL2RvYy9zcmMvc2dtbC9jYXRhbG9ncy5zZ21sCkBAIC0yMTQxLDggKzIxNDEsMTAgQEAg U0NSQU0tU0hBLTI1NiQ8cmVwbGFjZWFibGU+Jmx0O2l0ZXJhdGlvbiBjb3VudCZndDs8L3JlcGxh Y2VhYmxlPjo8cmVwbGFjZWFibGU+JmwKICAgICAgICBDb2x1bW5zIHVzZWQgdG8gZm9ybSA8cXVv dGU+cmVwbGljYSBpZGVudGl0eTwvcXVvdGU+IGZvciByb3dzOgogICAgICAgIDxsaXRlcmFsPmQ8 L2xpdGVyYWw+ID0gZGVmYXVsdCAocHJpbWFyeSBrZXksIGlmIGFueSksCiAgICAgICAgPGxpdGVy YWw+bjwvbGl0ZXJhbD4gPSBub3RoaW5nLAotICAgICAgIDxsaXRlcmFsPmY8L2xpdGVyYWw+ID0g YWxsIGNvbHVtbnMKLSAgICAgICA8bGl0ZXJhbD5pPC9saXRlcmFsPiA9IGluZGV4IHdpdGggPHN0 cnVjdGZpZWxkPmluZGlzcmVwbGlkZW50PC9zdHJ1Y3RmaWVsZD4gc2V0LCBvciBkZWZhdWx0Cisg ICAgICAgPGxpdGVyYWw+ZjwvbGl0ZXJhbD4gPSBhbGwgY29sdW1ucywKKyAgICAgICA8bGl0ZXJh bD5pPC9saXRlcmFsPiA9IGluZGV4IHdpdGgKKyAgICAgICA8c3RydWN0ZmllbGQ+aW5kaXNyZXBs aWRlbnQ8L3N0cnVjdGZpZWxkPiBzZXQgKHNhbWUgYXMgbm90aGluZyBpZiB0aGUKKyAgICAgICBp bmRleCB1c2VkIGdvdCBkcm9wcGVkKQogICAgICAgPC9wYXJhPjwvZW50cnk+CiAgICAgIDwvcm93 PgogCi0tIAoyLjE3LjEKCg== --=_6ae03071aa8c3ae40ee501050cf6f62a--