From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: danny.jones1994@live.com, Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Keyword docs missing, or mislabelled keywords
In-reply-to: 
 <CAKFQuwZFTmBoGzCHF7b_iorWcZKqoU0k_MtaTLz9XD6hm6Z6YQ@mail.gmail.com>
References: <163058588314.700.9808641086715132991@wrigleys.postgresql.org>
 <CAKFQuwZFTmBoGzCHF7b_iorWcZKqoU0k_MtaTLz9XD6hm6Z6YQ@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Thu, 02 Sep 2021 07:54:17 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2266035.1630611172.1@sss.pgh.pa.us>
Date: Thu, 02 Sep 2021 15:32:52 -0400
Message-ID: <2266036.1630611172@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2266036.1630611172%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Thu, Sep 2, 2021 at 7:11 AM PG Doc comments form <noreply@postgresql.org>
> wrote:
>> Missing:
>> RESTRICTED (as found in CREATE FUNCTION (PARALLEL RESTRICTED))
>> SAFE (as found in CREATE FUNCTION (PARALLEL SAFE))
>> UNSAFE (as found in CREATE FUNCTION (PARALLEL UNSAFE))

> I'll agree that the documentation for this doesn't fully describe the
> intricacies of the implementation, but the listing, at least for the
> PARALLEL related options, is correct.

In recent versions that listing is guaranteed correct, because it's
generated mechanically from the same keyword list the grammar uses.

But, as you say, it's not the whole story because some commands have
options that are not keywords in the eyes of the grammar, just identifiers
that are looked up later.  Indeed we encourage that where we can, to avoid
grammar bloat.  Maybe it'd be appropriate to add some text here about
that?  But I'm not sure where to stop, because there are lots of things
that are identifiers but an unsophisticated user might think are keywords.
(Index type names, for example.)

			regards, tom lane