pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
wrong output column title in example 4+ messages / 4 participants [nested] [flat]
Commits from this thread: 2020-06-25 463b808e75 185c6bc4ae Doc: correct nitpicky mistakes in array_position/array_positions examples.
* wrong output column title in example @ 2020-06-21 16:21 PG Doc comments form <noreply@postgresql.org> 2020-06-21 19:07 ` Re: wrong output column title in example Erik Rijkers <er@xs4all.nl> 0 siblings, 1 reply; 4+ messages in thread From: PG Doc comments form @ 2020-06-21 16:21 UTC (permalink / raw) To: pgsql-docs@lists.postgresql.org; +Cc: nick@cleaton.net The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/arrays.html Description: In the last code block in "8.15.5. Searching in Arrays", the column title in the output is "array_positions" for both examples, but it should be "array_position" for the second example. ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: wrong output column title in example 2020-06-21 16:21 wrong output column title in example PG Doc comments form <noreply@postgresql.org> @ 2020-06-21 19:07 ` Erik Rijkers <er@xs4all.nl> 2020-06-25 07:18 ` Re: wrong output column title in example Daniel Gustafsson <daniel@yesql.se> 0 siblings, 1 reply; 4+ messages in thread From: Erik Rijkers @ 2020-06-21 19:07 UTC (permalink / raw) To: nick@cleaton.net; pgsql-docs@lists.postgresql.org; +Cc: PG Doc comments form <noreply@postgresql.org> On 2020-06-21 18:21, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/arrays.html > Description: > > In the last code block in "8.15.5. Searching in Arrays", the column > title in > the output is "array_positions" for both examples, but it should be > "array_position" for the second example. Here is a doc fix/patch. Erik Rijkers Attachments:^ permalink raw reply [nested|flat] 4+ messages in threadarray.sgml.diff (text/x-diff, 314B) download
--- doc/src/sgml/array.sgml.orig 2020-06-21 21:02:54.254543177 +0200 +++ doc/src/sgml/array.sgml 2020-06-21 21:03:15.386894475 +0200 @@ -669,7 +669,7 @@ <programlisting> SELECT array_position(ARRAY['sun','mon','tue','wed','thu','fri','sat'], 'mon'); - array_positions + array_position ----------------- 2
* Re: wrong output column title in example 2020-06-21 16:21 wrong output column title in example PG Doc comments form <noreply@postgresql.org> 2020-06-21 19:07 ` Re: wrong output column title in example Erik Rijkers <er@xs4all.nl> @ 2020-06-25 07:18 ` Daniel Gustafsson <daniel@yesql.se> 2020-06-25 17:30 ` Re: wrong output column title in example Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 4+ messages in thread From: Daniel Gustafsson @ 2020-06-25 07:18 UTC (permalink / raw) To: Erik Rijkers <er@xs4all.nl>; +Cc: nick@cleaton.net, Pg Docs <pgsql-docs@lists.postgresql.org> > On 21 Jun 2020, at 21:07, Erik Rijkers <er@xs4all.nl> wrote: > > On 2020-06-21 18:21, PG Doc comments form wrote: >> The following documentation comment has been logged on the website: >> Page: https://www.postgresql.org/docs/12/arrays.html >> Description: >> In the last code block in "8.15.5. Searching in Arrays", the column title in >> the output is "array_positions" for both examples, but it should be >> "array_position" for the second example. > > Here is a doc fix/patch. While clearly in nitpicking territory, this isn't entirelty right either as the number of dashes needs to be updated to reflect the attr name. Looking it, the output also has incorrect indentation and lacks the "(1 row)" stanza which we tend to include when showing psql output as <programlisting>. The attached fixes these things too. cheers ./daniel Attachments:^ permalink raw reply [nested|flat] 4+ messages in threadarray_position.diff (application/octet-stream, 599B) download
diff --git a/doc/src/sgml/array.sgml b/doc/src/sgml/array.sgml index a473fa8ee8..56185b9b03 100644 --- a/doc/src/sgml/array.sgml +++ b/doc/src/sgml/array.sgml @@ -669,14 +669,16 @@ SELECT * FROM sal_emp WHERE pay_by_quarter && ARRAY[10000]; <programlisting> SELECT array_position(ARRAY['sun','mon','tue','wed','thu','fri','sat'], 'mon'); - array_positions ------------------ - 2 + array_position +---------------- + 2 +(1 row) SELECT array_positions(ARRAY[1, 4, 3, 1, 3, 4, 2, 1], 1); array_positions ----------------- {1,4,8} +(1 row) </programlisting> </para>
* Re: wrong output column title in example 2020-06-21 16:21 wrong output column title in example PG Doc comments form <noreply@postgresql.org> 2020-06-21 19:07 ` Re: wrong output column title in example Erik Rijkers <er@xs4all.nl> 2020-06-25 07:18 ` Re: wrong output column title in example Daniel Gustafsson <daniel@yesql.se> @ 2020-06-25 17:30 ` Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2020-06-25 17:30 UTC (permalink / raw) To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Erik Rijkers <er@xs4all.nl>; nick@cleaton.net, Pg Docs <pgsql-docs@lists.postgresql.org> Daniel Gustafsson <daniel@yesql.se> writes: > On 21 Jun 2020, at 21:07, Erik Rijkers <er@xs4all.nl> wrote: >> Here is a doc fix/patch. > While clearly in nitpicking territory, this isn't entirelty right either as the > number of dashes needs to be updated to reflect the attr name. Looking it, the > output also has incorrect indentation and lacks the "(1 row)" stanza which we > tend to include when showing psql output as <programlisting>. The attached > fixes these things too. Pushed to HEAD and v13. (The error seems old, but it's also so trivial that it didn't seem worth pushing further back.) regards, tom lane ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2020-06-25 17:30 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-06-21 16:21 wrong output column title in example PG Doc comments form <noreply@postgresql.org> 2020-06-21 19:07 ` Erik Rijkers <er@xs4all.nl> 2020-06-25 07:18 ` Daniel Gustafsson <daniel@yesql.se> 2020-06-25 17:30 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox