Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKO2q-0000fH-JP for pgsql-docs@arkaria.postgresql.org; Thu, 11 Mar 2021 16:20:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lKO2o-0003TT-Az for pgsql-docs@arkaria.postgresql.org; Thu, 11 Mar 2021 16:20:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKO2o-0003Nz-4o for pgsql-docs@lists.postgresql.org; Thu, 11 Mar 2021 16:20:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKO2i-0001vM-3U for pgsql-docs@lists.postgresql.org; Thu, 11 Mar 2021 16:20:13 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 12BGK5p32294220; Thu, 11 Mar 2021 11:20:05 -0500 From: Tom Lane To: Alex cc: Tatsuo Ishii , pgsql-docs@lists.postgresql.org Subject: Re: Invalid idle_in_transaction_session_timeout data type In-reply-to: References: <11783b8644ae5.7f3aa1e3b18b4.ref@yahoo.com> <11783b8644ae5.7f3aa1e3b18b4@yahoo.com> <20210311.211047.1106690547580793701.t-ishii@gmail.com> Comments: In-reply-to Alex message dated "Thu, 11 Mar 2021 12:23:29 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2294218.1615479605.1@sss.pgh.pa.us> Date: Thu, 11 Mar 2021 11:20:05 -0500 Message-ID: <2294219.1615479605@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk [ redirecting to pgsql-docs ] Alex writes: > In my opinion, it would be more clear if "Numeric with Unit" would be > specified on that property documentation, so that I can search more about > what that means (eventually a link pointing to details). > I saw "(integer)" so I assumed `show idle_in_transaction_session_timeout ` > will return an integer. This complaint isn't totally without merit. I wonder whether there is any value in listing a unit-ized GUC's default unit as part of the type info, so that we'd have entries like work_mem (integer, kilobytes) statement_timeout (integer, milliseconds) That'd both provide some concrete info about which unit applies, and cue unwary users that there might be more to it than just a number. I'm not sure whether this could replace the existing boilerplate phrases about "If this value is specified without units, it is taken as kilobytes", but it's sure more compact. regards, tom lane