Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 11C5FB5DBEE for ; Tue, 5 Jul 2011 16:40:05 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 06364-05 for ; Tue, 5 Jul 2011 19:39:59 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 2F28CB5DBCE for ; Tue, 5 Jul 2011 16:39:58 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p65Jdung023450; Tue, 5 Jul 2011 15:39:56 -0400 (EDT) To: Shigeru Hanada cc: pgsql-docs@postgresql.org Subject: Re: Improve FDW document (for 9.1) In-reply-to: <4E0C50A0.9070109@gmail.com> References: <4E0C50A0.9070109@gmail.com> Comments: In-reply-to Shigeru Hanada message dated "Thu, 30 Jun 2011 19:32:00 +0900" Date: Tue, 05 Jul 2011 15:39:56 -0400 Message-ID: <23449.1309894796@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201107/6 X-Sequence-Number: 6873 Shigeru Hanada writes: > During reading Albe's patch for FDW validator attached to "Bug in > SQL/MED?" posted to pgsql-hackers[1], I noticed that neither ALTER > commands nor USER MAPPING is mentioned in the description of FDW > validator in "Writing A Foreign Data Wrapper"[2]. The validator > function is also called for ALTER commands and USER MAPPING > manipulation, if any FDW option remains. > Please find attached a patch which adds a mention of ALTER and USER MAPPING. Applied with some editorial adjustments. regards, tom lane