Received: from localhost (unknown [200.46.204.182])
	by postgresql.org (Postfix) with ESMTP id B1DE92E0032;
	Wed, 21 Nov 2007 00:53:20 -0400 (AST)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.182]) (amavisd-maia, port 10024)
	with ESMTP id 88647-01; Wed, 21 Nov 2007 00:53:17 -0400 (AST)
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by postgresql.org (Postfix) with ESMTP id 8A8DB2E0035;
	Wed, 21 Nov 2007 00:53:17 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.1/8.14.1) with ESMTP id lAL4rCVT023540;
	Tue, 20 Nov 2007 23:53:12 -0500 (EST)
To: "Thomas H." <me@alternize.com>
cc: pgsql-bugs@postgresql.org, pgsql-docs@postgresql.org
Subject: Re: BUG #3767: tsearch2 index creation fatal crash 
In-reply-to: <4743B73C.4080606@alternize.com> 
References: <200711210225.lAL2PE8a064911@wwwmaster.postgresql.org>
	<47439A13.3000404@alternize.com> <21708.1195613326@sss.pgh.pa.us>
	<47439DDF.5010600@alternize.com> <22471.1195616725@sss.pgh.pa.us>
	<4743B73C.4080606@alternize.com>
Comments: In-reply-to "Thomas H." <me@alternize.com>
	message dated "Wed, 21 Nov 2007 05:42:36 +0100"
Date: Tue, 20 Nov 2007 23:53:12 -0500
Message-ID: <23539.1195620792@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200711/265
X-Sequence-Number: 18909

"Thomas H." <me@alternize.com> writes:
> i saw my mistake. i misinterpreted the examples to show the possibility 
> to convert *any* text by using casting to tsvector as an alternative to 
> using to_tsvector :)

Yeah, the examples in section 12.1.2 are not actually good practice:
both sides of the match should usually get normalized before comparison,
and these examples don't do that.

I'm not sure that putting in to_tsvector calls there would be an
improvement, though, since at that point we haven't introduced
to_tsvector.

Thoughts anyone?

			regards, tom lane