From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@gmail.com>
cc: Tomonari Katsumata <katsumata.tomonari@po.ntts.co.jp>,
 pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: disabling log_rotation_age feature.
In-reply-to: 
 <CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
References: <53992FF8.2060702@po.ntts.co.jp>
 <CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
Comments: In-reply-to Fujii Masao <masao.fujii@gmail.com>
 message dated "Thu, 12 Jun 2014 21:26:09 +0900"
Date: Thu, 12 Jun 2014 10:41:35 -0400
Message-ID: <23802.1402584095@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

Fujii Masao <masao.fujii@gmail.com> writes:
> On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata
> <katsumata.tomonari@po.ntts.co.jp> wrote:
>> The document tells us to set it to ZERO if we want to disable the feature.
>> However, the feature would be disabled if we set it less than one minute.

> That's because log_rotation_age expects the setting value in minutes.

> This is not a problem only for log_rotation_age. When setting the parameter
> which expects the value in seconds to less than one second, the setting value
> is implicitly reset to the default.

It's not "reset to default", it's set to zero due to rounding the fraction
down.  Some GUCs interpret zero specially, some don't.

I wonder if we should round fractions up instead of down in that logic?
It might be less surprising for those GUCs where zero is special, and
it seems like about a wash for most others.

			regards, tom lane


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs