public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: Euler Taveira de Oliveira <[email protected]>
Cc: PostgreSQL-documentation <[email protected]>
Subject: Re: log_min_duration_statement units
Date: Tue, 07 Apr 2009 18:43:59 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Bruce Momjian <[email protected]> writes:
> Euler Taveira de Oliveira wrote:
>> My English is not as good as yours but here is another try. Personally, I 
>> prefer the second one but...

> Great, I used your second version.  I had already done some of the ones
> you found, but you had many more.  I also used your "0 disables" wording
> consistently in the file.  Thanks for the help.  Committed.

You know, it suddenly strikes me that this is going in largely the wrong
direction.  Wasn't a key part of the reasoning for the GUC units support
to *eliminate* the need for people to know what the underlying
variable's unit is?  I certainly think that putting the unit info into
the text descriptions is a seriously bad idea.  It makes an already
overly wide view even wider, and the information is 100% redundant with
the "unit" column of the pg_settings view.

			regards, tom lane

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: log_min_duration_statement units
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox