Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 7A7171337999 for ; Mon, 7 Mar 2011 11:19:09 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 48647-07; Mon, 7 Mar 2011 15:19:02 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id D4CCC133798E; Mon, 7 Mar 2011 11:19:01 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p27FJ0bs023948; Mon, 7 Mar 2011 10:19:00 -0500 (EST) To: Thom Brown cc: pgsql-docs , pgadmin-hackers Subject: Re: [DOCS] Remove name as valid parameter for catalog functions In-reply-to: References: Comments: In-reply-to Thom Brown message dated "Mon, 07 Mar 2011 19:27:09 +0530" Date: Mon, 07 Mar 2011 10:19:00 -0500 Message-ID: <23947.1299511140@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-10 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201103/51 X-Sequence-Number: 18165 Thom Brown writes: > Patch attached which corrects the docs where catalog functions no > longer accept values of type name. Originally a note submitted by > someone on the docs, but this affects more than just the one they > mentioned. The reason those are phrased as "OID or name" is that what they take is regclass, which means that things like pg_total_relation_size('table_name') do in fact work. I think the proposed wording would leave people with the idea that they had to supply a numeric OID, which is a PITA and not by any means the expected usage. I agree that maybe the original wording could use some improvement, but I don't think that just removing "or name" is an improvement. regards, tom lane