Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eovbr-0003cY-Em for pgsql-docs@arkaria.postgresql.org; Thu, 22 Feb 2018 18:28:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eovbq-0004vH-7X for pgsql-docs@arkaria.postgresql.org; Thu, 22 Feb 2018 18:28:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eovbp-0004v8-V5 for pgsql-docs@lists.postgresql.org; Thu, 22 Feb 2018 18:28:46 +0000 Received: from [66.111.4.26] (helo=out2-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eovbj-0006Ht-P5 for pgsql-docs@lists.postgresql.org; Thu, 22 Feb 2018 18:28:44 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EA75220E73; Thu, 22 Feb 2018 13:28:18 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Thu, 22 Feb 2018 13:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=LaTuFN puhXfHJiKt52ORZ/5Onki39vcbnoS8ZuUjHZ8=; b=H5Vro4P6MVSgVxQov0Y/qe MMlKwuvRjbou1J5p05NEycjor/+Nd/0d9n5UX2GWoCWjByUPANIB9+oN1Ii7hfVs B5NkeFcjqogWJUmBa1AZSbxCbhYBH6ZGNAMKL2miIgGs2quThrw3Md+PWKaxpmNq GgSJsE78+aEeUPyni8RTNOa2hyq8CZN+HgCdHyKz0cChAZ9SH5lbgS90kVA9dLZw hXdifc8VewPxvBwVeU79Riav70zPEm6HjucGwiFzljK7KDIEk8w7zwRPJ2WCGZjY xh3eITAteSsk3KJHRLJ1OMML3g+gVjF4sjXQHESYBZ3JOMAZqomKzjowAfhnffeA == X-ME-Sender: Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id A77F27E570; Thu, 22 Feb 2018 13:28:18 -0500 (EST) Subject: Re: removal of md5 from example code To: jonwolski@gmail.com, pgsql-docs@lists.postgresql.org References: <20180117161459.3623.50555@wrigleys.postgresql.org> From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <240575e3-3734-a5c2-eb1a-543715b9c7c7@2ndquadrant.com> Date: Thu, 22 Feb 2018 13:28:18 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180117161459.3623.50555@wrigleys.postgresql.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.26 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 1/17/18 11:14, PG Doc comments form wrote: > The documentation at > https://www.postgresql.org/docs/current/static/citext.html shows an example > using md5 for password hashes. This is generally a bad practice and not > relevant to the feature documented. > > I recommend removing the password column from this example or replacing the > md5 hash with something more secure (a secure hash algorithm with a salt). This has been fixed in the master branch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services