Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id AEA9A9FA491 for ; Fri, 10 Nov 2006 18:24:24 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 41328-06 for ; Fri, 10 Nov 2006 18:24:21 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey- Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 5EFA09F9F79 for ; Fri, 10 Nov 2006 18:24:19 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id kAAMOAYw002472; Fri, 10 Nov 2006 17:24:10 -0500 (EST) To: theo@flame.co.za cc: pgsql-docs@postgresql.org Subject: Re: Documentation update for PQexecParams In-reply-to: <1163152973.2422.14.camel@theo-laptop.int.coza.net.za> References: <1163009239.2384.2.camel@josh> <20061109144348.GA10157@fetter.org> <1163084688.2448.28.camel@theo-laptop.int.coza.net.za> <200611101050.43400.peter_e@gmx.net> <1163152973.2422.14.camel@theo-laptop.int.coza.net.za> Comments: In-reply-to Theo Kramer message dated "Fri, 10 Nov 2006 12:02:53 +0200" Date: Fri, 10 Nov 2006 17:24:10 -0500 Message-ID: <2471.1163197450@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200611/8 X-Sequence-Number: 3842 Theo Kramer writes: > On Fri, 2006-11-10 at 10:50 +0100, Peter Eisentraut wrote: >> The patch is backwards. > Thanks - re-done and re-attached I applied the part of this that reformats the PQexecParams argument descriptions --- I agree that makes it more readable. I did not like the proposed table of datatypes though. It strikes me as incomplete, unhelpful, and in places downright misleading. For instance, I don't see the point of listing ODBC type codes; they are irrelevant to libpq, and the only likely outcome of listing them is that someone might think he could use them for paramTypes[] entries. The description of the binary formats was not helpful either, as it avoided any of the useful details (endianness etc), as well as portability issues like whether timestamps are int or float. regards, tom lane