public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Susanne Ebrecht <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Grzegorz Szpetkowski <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: createuser/dropuser username
Date: Thu, 08 Sep 2011 14:37:44 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Bruce Momjian <[email protected]> writes:
> Alvaro Herrera wrote:
>> Excerpts from Bruce Momjian's message of jue sep 08 11:52:04 -0300 2011:
>>> I started going in that direction and stopped because of this example
>>> in our docs:
>>> vacuumdb --analyze --verbose --table 'foo(bar)' xyzzy

>> Maybe do it unless there are parens.

> OK, let me give that a try.

I've been thinking more about this, and realized that there is one
killer argument in favor of not auto-quoting, at least for arguments
that represent table names: if we quote, there is no way to specify
a schema-qualified name.

I'm too lazy to troll the archives to verify this, but I am moderately
sure that this point never came up in the original discussions where
we concluded that auto-quoting command-line arguments was a good policy,
because that was before we'd implemented schemas.

So what I'm thinking right now is that we indeed should not auto-quote
table- or index-name arguments.  However, usernames and database names
taken from the command line are still going to be auto-quoted, because
that's how things work in connection requests.  Is it going to be
confusing that some things are quoted and some not?

(Of course, any such change would be non-backwards-compatible and would
have to be suitably documented and release-noted.)

The backwards-compatible alternative would be to invent additional
schema option arguments so that you could write something like
"reindexdb --schema foo --table bar", but that seems pretty darn ugly.

			regards, tom lane

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: createuser/dropuser username
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox