pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Pg_dumpall
4+ messages / 4 participants
[nested] [flat]

Commits from this thread:
  2018-04-08 893e9e6540 2ecd5fba9b 3d465826f2 c5261348a6 4716c9e70e bd213fd66a  Doc: clarify explanation of pg_dump usage.
* Pg_dumpall
@ 2018-04-07 14:55 PG Doc comments form <noreply@postgresql.org>
  2018-04-08 17:01 ` Re: Pg_dumpall Jonathan S. Katz <jkatz@postgresql.org>
  0 siblings, 1 reply; 4+ messages in thread

From: PG Doc comments form @ 2018-04-07 14:55 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org; +Cc: sfmconsult@gmail.com

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/static/backup-dump.html
Description:

"The basic usage of this command is:

pg_dumpall > outfile
The resulting dump can be restored with psql:

psql -f infile postgres
(Actually, you can specify any existing database name to..."

Should this not read :
 psql-f outfile postgres


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Pg_dumpall
  2018-04-07 14:55 Pg_dumpall PG Doc comments form <noreply@postgresql.org>
@ 2018-04-08 17:01 ` Jonathan S. Katz <jkatz@postgresql.org>
  2018-04-08 20:21   ` Re: Pg_dumpall Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 4+ messages in thread

From: Jonathan S. Katz @ 2018-04-08 17:01 UTC (permalink / raw)
  To: sfmconsult@gmail.com; pgsql-docs@lists.postgresql.org

Hi,

> On Apr 7, 2018, at 10:55 AM, PG Doc comments form <noreply@postgresql.org> wrote:
> 
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/10/static/backup-dump.html
> Description:
> 
> "The basic usage of this command is:
> 
> pg_dumpall > outfile
> The resulting dump can be restored with psql:
> 
> psql -f infile postgres
> (Actually, you can specify any existing database name to..."
> 
> Should this not read :
> psql-f outfile postgres

Technically it is correct: you’re dumping data to an output file,
and reading the data in from an input file.  The documentation
also makes reference to what the “outfile” and “infile” represent.

That being said, I can see how it can be confusing particularly
if you are reading through the documentation quickly.  Perhaps
a name like “dumpfile” would be more clear?

Jonathan





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Pg_dumpall
  2018-04-07 14:55 Pg_dumpall PG Doc comments form <noreply@postgresql.org>
  2018-04-08 17:01 ` Re: Pg_dumpall Jonathan S. Katz <jkatz@postgresql.org>
@ 2018-04-08 20:21   ` Tom Lane <tgl@sss.pgh.pa.us>
  2018-04-09 13:59     ` Re: Pg_dumpall Steve M <sfmconsult@gmail.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Tom Lane @ 2018-04-08 20:21 UTC (permalink / raw)
  To: Jonathan S. Katz <jkatz@postgresql.org>; +Cc: sfmconsult@gmail.com; pgsql-docs@lists.postgresql.org

"Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> On Apr 7, 2018, at 10:55 AM, PG Doc comments form <noreply@postgresql.org> wrote:
>> Should this not read :
>> psql-f outfile postgres

> Technically it is correct: you’re dumping data to an output file,
> and reading the data in from an input file.  The documentation
> also makes reference to what the “outfile” and “infile” represent.

> That being said, I can see how it can be confusing particularly
> if you are reading through the documentation quickly.  Perhaps
> a name like “dumpfile” would be more clear?

+1 ... I thought the same.  Will go fix it.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Pg_dumpall
  2018-04-07 14:55 Pg_dumpall PG Doc comments form <noreply@postgresql.org>
  2018-04-08 17:01 ` Re: Pg_dumpall Jonathan S. Katz <jkatz@postgresql.org>
  2018-04-08 20:21   ` Re: Pg_dumpall Tom Lane <tgl@sss.pgh.pa.us>
@ 2018-04-09 13:59     ` Steve M <sfmconsult@gmail.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Steve M @ 2018-04-09 13:59 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Jonathan S. Katz <jkatz@postgresql.org>; pgsql-docs@lists.postgresql.org

Thank you for responding.


*Best regards,*

*Steve Maio*

On Sun, Apr 8, 2018 at 4:21 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
> >> On Apr 7, 2018, at 10:55 AM, PG Doc comments form <
> noreply@postgresql.org> wrote:
> >> Should this not read :
> >> psql-f outfile postgres
>
> > Technically it is correct: you’re dumping data to an output file,
> > and reading the data in from an input file.  The documentation
> > also makes reference to what the “outfile” and “infile” represent.
>
> > That being said, I can see how it can be confusing particularly
> > if you are reading through the documentation quickly.  Perhaps
> > a name like “dumpfile” would be more clear?
>
> +1 ... I thought the same.  Will go fix it.
>
>                         regards, tom lane
>

^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2018-04-09 13:59 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-04-07 14:55 Pg_dumpall PG Doc comments form <noreply@postgresql.org>
2018-04-08 17:01 ` Jonathan S. Katz <jkatz@postgresql.org>
2018-04-08 20:21   ` Tom Lane <tgl@sss.pgh.pa.us>
2018-04-09 13:59     ` Steve M <sfmconsult@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox