public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: "recovering prepared transaction" after server restart message
Date: Fri, 03 Nov 2006 01:48:05 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <e3b306b71615a24e1be5e713ad3df048@>
References: <e3b306b71615a24e1be5e713ad3df048@>

"Joachim Wieland" <[email protected]> writes:
> There have been several reports that people could not vacuum any more or
> observed strange locks even after server restart. The reason was that they
> still had uncommitted prepared transactions around.

> I wonder if it could help to change the log level from
>     ereport(LOG,
>             (errmsg("recovering prepared transaction %u", xid)));
> to WARNING maybe in order to make that message more striking within the
> normal startup messages.

That doesn't seem like a good idea.  In the first place, recovering
prepared xacts is exactly what system restart is *supposed* to do, and
so calling it a WARNING seems out of line.  (I'm not real sure why that
message is even LOG level, rather than DEBUG1 or below.)  In the second
place, this wouldn't help anyone unless they tried to fix their problem
by restarting the server --- a mentality suited only for Windows users,
and certainly not something a production system is going to do lightly
--- and then thought to look in the postmaster log, which the average
Windows user wouldn't.

I agree that there's a usability issue here though; I've been burnt by
forgotten prepared xacts myself (eg by control-C'ing pg_regress at just
the wrong time).  Would it help if we included prepared xacts in the
pg_stat_activity view?  Is there any other place we could make them
more visible during normal server operation?

			regards, tom lane

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: "recovering prepared transaction" after server restart message
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox