Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229])
	by mail.postgresql.org (Postfix) with ESMTP id 0D842F5D5A3
	for <pgsql-docs@postgresql.org>; Wed, 14 Dec 2011 00:27:55 -0400 (AST)
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <tgl@sss.pgh.pa.us>) id 1RagRd-0004dK-OU
	for pgsql-docs@postgresql.org; Wed, 14 Dec 2011 04:27:55 +0000
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id pBE4Rb9b027417;
	Tue, 13 Dec 2011 23:27:37 -0500 (EST)
To: Bruce Momjian <bruce@momjian.us>
cc: Scott Marlowe <scott.marlowe@gmail.com>,
	Jaime Casanova <jaime@2ndquadrant.com>,
	pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: CREATE USER 
In-reply-to: <201112140139.pBE1dEo03975@momjian.us> 
References: <201112140139.pBE1dEo03975@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Tue, 13 Dec 2011 20:39:14 -0500"
Date: Tue, 13 Dec 2011 23:27:37 -0500
Message-ID: <27416.1323836857@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Pg-Spam-Score: -4.2 (----)
X-Archive-Number: 201112/38
X-Sequence-Number: 7145

Bruce Momjian <bruce@momjian.us> writes:
> Well, I know we support the new pg_dump dumping back to 7.1, but I don't
> know what our policy is for accepting old dumps.

We're still going to very large lengths to load pre-7.3 dumps; see
for instance ConvertTriggerToFK() in trigger.c.  I'm not aware of any
policy that would suggest blowing off pre-8.1 dumps should be
acceptable.  Yeah, it's true that the *recommended* procedure is to
use the newer pg_dump, but people aren't always in a position to do
that.

I think it might be sane to emit a WARNING suggesting that CREATEUSER
might not mean what you think, but failing is probably not good.

			regards, tom lane