pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedrename of a view
22+ messages / 6 participants
[nested] [flat]
* rename of a view
@ 2007-06-28 11:31 Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-28 15:27 ` Re: rename of a view Neil Conway <neilc@samurai.com>
0 siblings, 2 replies; 22+ messages in thread
From: Susanne Ebrecht @ 2007-06-28 11:31 UTC (permalink / raw)
To: pgsql-docs
Hi all,
I got the question: how can I rename a view?
At the first moment, I have had no idea ... and I asked the German guys
at IRC.
They have had no idea too.
Than I just tried: alter table pgview rename to bettername;
that works, but there is no hint at the documentation, that you can
rename a view via alter table.
Is it possible to add a hint for this to the documentation?
Regards,
Susanne
--
Susanne Ebrecht,
52066 Aachen, Germany
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
@ 2007-06-28 14:16 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
1 sibling, 1 reply; 22+ messages in thread
From: Tom Lane @ 2007-06-28 14:16 UTC (permalink / raw)
To: Susanne Ebrecht <miracee@miracee.de>; +Cc: pgsql-docs
Susanne Ebrecht <miracee@miracee.de> writes:
> that works, but there is no hint at the documentation, that you can
> rename a view via alter table.
It is mentioned someplace (don't remember where). Where would you have
expected to find it?
regards, tom lane
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-06-29 18:32 ` David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
0 siblings, 1 reply; 22+ messages in thread
From: David Fetter @ 2007-06-29 18:32 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
On Thu, Jun 28, 2007 at 10:16:51AM -0400, Tom Lane wrote:
> Susanne Ebrecht <miracee@miracee.de> writes:
> > that works, but there is no hint at the documentation, that you
> > can rename a view via alter table.
>
> It is mentioned someplace (don't remember where). Where would you
> have expected to find it?
I'd expect to find it in an ALTER VIEW document.
Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
@ 2007-06-30 00:16 ` David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
0 siblings, 1 reply; 22+ messages in thread
From: David Fetter @ 2007-06-30 00:16 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
On Fri, Jun 29, 2007 at 11:32:19AM -0700, David Fetter wrote:
> On Thu, Jun 28, 2007 at 10:16:51AM -0400, Tom Lane wrote:
> > Susanne Ebrecht <miracee@miracee.de> writes:
> > > that works, but there is no hint at the documentation, that you
> > > can rename a view via alter table.
> >
> > It is mentioned someplace (don't remember where). Where would you
> > have expected to find it?
>
> I'd expect to find it in an ALTER VIEW document.
>
> Cheers,
> D
The attached patch and file implement and document
ALTER [VIEW | SEQUENCE] RENAME TO
The file goes in doc/src/sgml/ref and the patch should just apply to
CVS HEAD.
Thanks to Neil Conway for all the help putting this together :)
Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
Attachments:
alter_view.sgml (text/sgml, 2.3K) download
<!--
$PostgreSQL: pgsql/doc/src/sgml/ref/alter_view.sgml,v 1.0 Fri Jun 29 2007 fetter Exp $
PostgreSQL documentation
-->
<refentry id="SQL-ALTERVIEW">
<refmeta>
<refentrytitle id="SQL-ALTERVIEW-TITLE">ALTER VIEW</refentrytitle>
<refmiscinfo>SQL - Language Statements</refmiscinfo>
</refmeta>
<refnamediv>
<refname>ALTER VIEW</refname>
<refpurpose>change a view</refpurpose>
</refnamediv>
<indexterm zone="sql-alterview">
<primary>ALTER VIEW</primary>
</indexterm>
<refsynopsisdiv>
<synopsis>
ALTER VIEW <replaceable>name</replaceable> RENAME TO <replaceable>newname</replaceable>
</synopsis>
</refsynopsisdiv>
<refsect1>
<title>Description</title>
<para>
<command>ALTER VIEW</command> changes the definition of a
view.
</para>
<para>
You must own the view to use <command>ALTER VIEW</>.
To alter the owner, you must also be a direct or indirect member of the new
owning role, and that role must have <literal>CREATE</literal> privilege on
the view's schema. (These restrictions enforce that altering the
owner doesn't do anything you couldn't do by dropping and recreating the
view. However, a superuser can alter ownership of any view
anyway.)
</para>
</refsect1>
<refsect1>
<title>Parameters</title>
<variablelist>
<varlistentry>
<term><replaceable class="parameter">name</replaceable></term>
<listitem>
<para>
The name (optionally schema-qualified) of an existing view.
</para>
</listitem>
</varlistentry>
<varlistentry>
<term><replaceable class="parameter">newname</replaceable></term>
<listitem>
<para>
The new name of the view.
</para>
</listitem>
</varlistentry>
</variablelist>
</refsect1>
<refsect1>
<title>Examples</title>
<para>
To rename the view <literal>foo</literal> to
<literal>bar</literal>:
<programlisting>
ALTER VIEW foo RENAME TO bar;
</programlisting>
</para>
<refsect1>
<title>Compatibility</title>
<para>
There is no <command>ALTER VIEW</command> statement in the SQL
standard.
</para>
</refsect1>
<refsect1>
<title>See Also</title>
<simplelist type="inline">
<member><xref linkend="sql-createview" endterm="sql-createview-title"></member>
<member><xref linkend="sql-dropview" endterm="sql-dropview-title"></member>
</simplelist>
</refsect1>
</refentry>
alter_view_sequence.diff (text/plain, 8.1K) download
Index: doc/src/sgml/reference.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/reference.sgml,v
retrieving revision 1.63
diff -c -r1.63 reference.sgml
*** doc/src/sgml/reference.sgml 26 Apr 2007 16:13:08 -0000 1.63
--- doc/src/sgml/reference.sgml 30 Jun 2007 00:14:47 -0000
***************
*** 53,58 ****
--- 53,59 ----
&alterTrigger;
&alterType;
&alterUser;
+ &alterView;
&analyze;
&begin;
&checkpoint;
Index: doc/src/sgml/ref/allfiles.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/allfiles.sgml,v
retrieving revision 1.70
diff -c -r1.70 allfiles.sgml
*** doc/src/sgml/ref/allfiles.sgml 26 Apr 2007 16:13:08 -0000 1.70
--- doc/src/sgml/ref/allfiles.sgml 30 Jun 2007 00:14:47 -0000
***************
*** 25,30 ****
--- 25,31 ----
<!entity alterTrigger system "alter_trigger.sgml">
<!entity alterType system "alter_type.sgml">
<!entity alterUser system "alter_user.sgml">
+ <!entity alterView system "alter_view.sgml">
<!entity analyze system "analyze.sgml">
<!entity begin system "begin.sgml">
<!entity checkpoint system "checkpoint.sgml">
Index: doc/src/sgml/ref/alter_sequence.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/alter_sequence.sgml,v
retrieving revision 1.16
diff -c -r1.16 alter_sequence.sgml
*** doc/src/sgml/ref/alter_sequence.sgml 31 Jan 2007 23:26:02 -0000 1.16
--- doc/src/sgml/ref/alter_sequence.sgml 30 Jun 2007 00:14:47 -0000
***************
*** 29,34 ****
--- 29,35 ----
[ RESTART [ WITH ] <replaceable class="parameter">start</replaceable> ] [ CACHE <replaceable class="parameter">cache</replaceable> ] [ [ NO ] CYCLE ]
[ OWNED BY { <replaceable class="parameter">table</replaceable>.<replaceable class="parameter">column</replaceable> | NONE } ]
ALTER SEQUENCE <replaceable class="parameter">name</replaceable> SET SCHEMA <replaceable class="parameter">new_schema</replaceable>
+ ALTER SEQUENCE <replaceable class="parameter">name</replaceable> RENAME TO <replaceable class="parameter">new_name</replaceable>
</synopsis>
</refsynopsisdiv>
***************
*** 190,195 ****
--- 191,207 ----
</para>
</listitem>
</varlistentry>
+
+ <varlistentry>
+ <term><literal>RENAME TO</literal> <replaceable class="parameter">new_name</replaceable></term>
+ <listitem>
+ <para>
+ The <literal>RENAME TO</literal> option causes the sequence to be
+ renamed.
+ </para>
+ </listitem>
+ </varlistentry>
+
</variablelist>
</para>
</refsect1>
Index: src/backend/commands/alter.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/commands/alter.c,v
retrieving revision 1.23
diff -c -r1.23 alter.c
*** src/backend/commands/alter.c 26 Mar 2007 16:58:38 -0000 1.23
--- src/backend/commands/alter.c 30 Jun 2007 00:14:47 -0000
***************
*** 83,88 ****
--- 83,90 ----
break;
case OBJECT_TABLE:
+ case OBJECT_SEQUENCE:
+ case OBJECT_VIEW:
case OBJECT_INDEX:
case OBJECT_COLUMN:
case OBJECT_TRIGGER:
***************
*** 96,101 ****
--- 98,105 ----
switch (stmt->renameType)
{
case OBJECT_TABLE:
+ case OBJECT_SEQUENCE:
+ case OBJECT_VIEW:
case OBJECT_INDEX:
{
/*
Index: src/backend/commands/tablecmds.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/commands/tablecmds.c,v
retrieving revision 1.228
diff -c -r1.228 tablecmds.c
*** src/backend/commands/tablecmds.c 23 Jun 2007 22:12:50 -0000 1.228
--- src/backend/commands/tablecmds.c 30 Jun 2007 00:14:48 -0000
***************
*** 1633,1640 ****
bool relhastriggers;
/*
! * Grab an exclusive lock on the target table or index, which we will NOT
! * release until end of transaction.
*/
targetrelation = relation_open(myrelid, AccessExclusiveLock);
--- 1633,1640 ----
bool relhastriggers;
/*
! * Grab an exclusive lock on the target table, index, sequence or
! * view, which we will NOT release until end of transaction.
*/
targetrelation = relation_open(myrelid, AccessExclusiveLock);
Index: src/backend/parser/gram.y
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/parser/gram.y,v
retrieving revision 2.596
diff -c -r2.596 gram.y
*** src/backend/parser/gram.y 23 Jun 2007 22:12:51 -0000 2.596
--- src/backend/parser/gram.y 30 Jun 2007 00:14:50 -0000
***************
*** 4546,4551 ****
--- 4546,4569 ----
n->newname = $6;
$$ = (Node *)n;
}
+ | ALTER SEQUENCE relation_expr RENAME TO name
+ {
+ RenameStmt *n = makeNode(RenameStmt);
+ n->renameType = OBJECT_SEQUENCE;
+ n->relation = $3;
+ n->subname = NULL;
+ n->newname = $6;
+ $$ = (Node *)n;
+ }
+ | ALTER VIEW relation_expr RENAME TO name
+ {
+ RenameStmt *n = makeNode(RenameStmt);
+ n->renameType = OBJECT_VIEW;
+ n->relation = $3;
+ n->subname = NULL;
+ n->newname = $6;
+ $$ = (Node *)n;
+ }
| ALTER INDEX relation_expr RENAME TO name
{
RenameStmt *n = makeNode(RenameStmt);
Index: src/backend/tcop/utility.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/tcop/utility.c,v
retrieving revision 1.282
diff -c -r1.282 utility.c
*** src/backend/tcop/utility.c 28 Jun 2007 00:02:39 -0000 1.282
--- src/backend/tcop/utility.c 30 Jun 2007 00:14:50 -0000
***************
*** 1574,1579 ****
--- 1574,1582 ----
case OBJECT_SCHEMA:
tag = "ALTER SCHEMA";
break;
+ case OBJECT_SEQUENCE:
+ tag = "ALTER SEQUENCE";
+ break;
case OBJECT_COLUMN:
case OBJECT_TABLE:
tag = "ALTER TABLE";
***************
*** 1584,1589 ****
--- 1587,1595 ----
case OBJECT_TRIGGER:
tag = "ALTER TRIGGER";
break;
+ case OBJECT_VIEW:
+ tag = "ALTER VIEW";
+ break;
default:
tag = "???";
break;
Index: src/bin/psql/tab-complete.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/bin/psql/tab-complete.c,v
retrieving revision 1.165
diff -c -r1.165 tab-complete.c
*** src/bin/psql/tab-complete.c 13 Jun 2007 23:59:47 -0000 1.165
--- src/bin/psql/tab-complete.c 30 Jun 2007 00:14:51 -0000
***************
*** 602,608 ****
static const char *const list_ALTER[] =
{"AGGREGATE", "CONVERSION", "DATABASE", "DOMAIN", "FUNCTION",
"GROUP", "INDEX", "LANGUAGE", "OPERATOR", "ROLE", "SCHEMA", "SEQUENCE", "TABLE",
! "TABLESPACE", "TRIGGER", "TYPE", "USER", NULL};
COMPLETE_WITH_LIST(list_ALTER);
}
--- 602,608 ----
static const char *const list_ALTER[] =
{"AGGREGATE", "CONVERSION", "DATABASE", "DOMAIN", "FUNCTION",
"GROUP", "INDEX", "LANGUAGE", "OPERATOR", "ROLE", "SCHEMA", "SEQUENCE", "TABLE",
! "TABLESPACE", "TRIGGER", "TYPE", "USER", "VIEW", NULL};
COMPLETE_WITH_LIST(list_ALTER);
}
***************
*** 714,720 ****
{
static const char *const list_ALTERSEQUENCE[] =
{"INCREMENT", "MINVALUE", "MAXVALUE", "RESTART", "NO", "CACHE", "CYCLE",
! "SET SCHEMA", NULL};
COMPLETE_WITH_LIST(list_ALTERSEQUENCE);
}
--- 714,720 ----
{
static const char *const list_ALTERSEQUENCE[] =
{"INCREMENT", "MINVALUE", "MAXVALUE", "RESTART", "NO", "CACHE", "CYCLE",
! "SET SCHEMA", "RENAME TO", NULL};
COMPLETE_WITH_LIST(list_ALTERSEQUENCE);
}
***************
*** 728,733 ****
--- 728,742 ----
COMPLETE_WITH_LIST(list_ALTERSEQUENCE2);
}
+ /* ALTER VIEW <name> */
+ else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
+ pg_strcasecmp(prev2_wd, "VIEW") == 0)
+ {
+ static const char *const list_ALTERVIEW[] =
+ {"RENAME TO"};
+
+ COMPLETE_WITH_LIST(list_ALTERVIEW);
+ }
/* ALTER TRIGGER <name>, add ON */
else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
pg_strcasecmp(prev2_wd, "TRIGGER") == 0)
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
@ 2007-06-30 04:15 ` Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 22+ messages in thread
From: Euler Taveira de Oliveira @ 2007-06-30 04:15 UTC (permalink / raw)
To: David Fetter <david@fetter.org>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
David Fetter wrote:
pgsql-patches will be more appropriate for a patch. Could you post there
so your patch won't be forget?
> The attached patch and file implement and document
>
> ALTER [VIEW | SEQUENCE] RENAME TO
>
I didn't test your patch, but I think we could disallow ALTER TABLE to
rename sequence and view because we have specific new commands for it or
at least put a NOTICE saying such a thing.
--
Euler Taveira de Oliveira
http://www.timbira.com/
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
@ 2007-06-30 04:26 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
0 siblings, 1 reply; 22+ messages in thread
From: Tom Lane @ 2007-06-30 04:26 UTC (permalink / raw)
To: Euler Taveira de Oliveira <euler@timbira.com>; +Cc: David Fetter <david@fetter.org>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
Euler Taveira de Oliveira <euler@timbira.com> writes:
> I didn't test your patch, but I think we could disallow ALTER TABLE to
> rename sequence and view
There is exactly 0 chance of that happening, because it's always worked
historically.
Personally I don't see a lot of value in this patch at all, but maybe
it is small enough to be justifiable. I am not sure it is complete
however, in the sense of touching everyplace that should be touched,
especially documentation-wise? I mean, its only excuse to live is
that "I expected to find this functionality under $foo", and so I'm
wondering how many values of $foo there are.
regards, tom lane
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-06-30 05:33 ` Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 22+ messages in thread
From: Neil Conway @ 2007-06-30 05:33 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Euler Taveira de Oliveira <euler@timbira.com>; David Fetter <david@fetter.org>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
On Sat, 2007-30-06 at 00:26 -0400, Tom Lane wrote:
> There is exactly 0 chance of that happening, because it's always worked
> historically.
Agreed, but I think the patch should disallow ALTER VIEW ... RENAME on a
non-view, and ALTER SEQUENCE ... RENAME on a non-sequence.
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
@ 2007-06-30 05:36 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:40 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
0 siblings, 2 replies; 22+ messages in thread
From: Tom Lane @ 2007-06-30 05:36 UTC (permalink / raw)
To: Neil Conway <neilc@samurai.com>; +Cc: Euler Taveira de Oliveira <euler@timbira.com>; David Fetter <david@fetter.org>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
Neil Conway <neilc@samurai.com> writes:
> On Sat, 2007-30-06 at 00:26 -0400, Tom Lane wrote:
>> There is exactly 0 chance of that happening, because it's always worked
>> historically.
> Agreed, but I think the patch should disallow ALTER VIEW ... RENAME on a
> non-view, and ALTER SEQUENCE ... RENAME on a non-sequence.
No objection to that; it'd square with our treatment of TYPE and DOMAIN
commands. What I'm wondering though is whether the whole patch has
a reason to live at all, as compared to documenting someplace more
prominent than now that ALTER TABLE works on views & sequences.
regards, tom lane
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-06-30 05:40 ` David Fetter <david@fetter.org>
1 sibling, 0 replies; 22+ messages in thread
From: David Fetter @ 2007-06-30 05:40 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Neil Conway <neilc@samurai.com>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
On Sat, Jun 30, 2007 at 01:36:22AM -0400, Tom Lane wrote:
> Neil Conway <neilc@samurai.com> writes:
> > On Sat, 2007-30-06 at 00:26 -0400, Tom Lane wrote:
> >> There is exactly 0 chance of that happening, because it's always
> >> worked historically.
>
> > Agreed, but I think the patch should disallow ALTER VIEW ...
> > RENAME on a non-view, and ALTER SEQUENCE ... RENAME on a
> > non-sequence.
>
> No objection to that; it'd square with our treatment of TYPE and
> DOMAIN commands. What I'm wondering though is whether the whole
> patch has a reason to live at all, as compared to documenting
> someplace more prominent than now that ALTER TABLE works on views &
> sequences.
How could it be prominent short of documentation of the thing people
would expect, which is ALTER [SEQUENCE | VIEW] RENAME TO ... ? I
suppose we could document that they're actually done by ALTER TABLE,
but that just seems like a huge POLA violation, along with assuming
way too much knowledge of how sequences and views are implemented.
Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-06-30 05:43 ` Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 22+ messages in thread
From: Neil Conway @ 2007-06-30 05:43 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Euler Taveira de Oliveira <euler@timbira.com>; David Fetter <david@fetter.org>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
On Sat, 2007-30-06 at 01:36 -0400, Tom Lane wrote:
> No objection to that; it'd square with our treatment of TYPE and DOMAIN
> commands. What I'm wondering though is whether the whole patch has
> a reason to live at all, as compared to documenting someplace more
> prominent than now that ALTER TABLE works on views & sequences.
Using ALTER TABLE to rename views and sequences is quite counter-
intuitive, and has been a repeated source of confusion for users. Sure,
we can document that behavior more prominently, but it seems to me it
would be more straightforward in the long-run to just make the system
behave more intuitively in the first place. As an added bonus, it takes
very little new code to implement.
For the ALTER SEQUENCE case, I think it's also a little weird to have an
ALTER SEQUENCE command that modifies some of the properties of a
sequence, but not the sequence's name. While that argument doesn't apply
to ALTER VIEW at the moment, recent history suggests that it may only be
a matter of time before we need to add an ALTER VIEW command anyway...
(for instance, to control the properties of materialized or updateable
views).
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
@ 2007-06-30 05:48 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
0 siblings, 1 reply; 22+ messages in thread
From: Tom Lane @ 2007-06-30 05:48 UTC (permalink / raw)
To: Neil Conway <neilc@samurai.com>; +Cc: Euler Taveira de Oliveira <euler@timbira.com>; David Fetter <david@fetter.org>; Susanne Ebrecht <miracee@miracee.de>; pgsql-docs
Neil Conway <neilc@samurai.com> writes:
> For the ALTER SEQUENCE case, I think it's also a little weird to have an
> ALTER SEQUENCE command that modifies some of the properties of a
> sequence, but not the sequence's name. While that argument doesn't apply
> to ALTER VIEW at the moment, recent history suggests that it may only be
> a matter of time before we need to add an ALTER VIEW command anyway...
OK, that's a fairly convincing argument. Fire away.
(I'm still not sure you found all the relevant places in the
documentation, however.)
regards, tom lane
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-07-01 19:55 ` David Fetter <david@fetter.org>
2007-07-02 04:03 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 01:34 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
0 siblings, 2 replies; 22+ messages in thread
From: David Fetter @ 2007-07-01 19:55 UTC (permalink / raw)
To: PostgreSQL Patches <pgsql-patches@postgresql.org>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Neil Conway <neilc@samurai.com>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
On Sat, Jun 30, 2007 at 01:48:51AM -0400, Tom Lane wrote:
> Neil Conway <neilc@samurai.com> writes:
> > For the ALTER SEQUENCE case, I think it's also a little weird to
> > have an ALTER SEQUENCE command that modifies some of the
> > properties of a sequence, but not the sequence's name. While that
> > argument doesn't apply to ALTER VIEW at the moment, recent history
> > suggests that it may only be a matter of time before we need to
> > add an ALTER VIEW command anyway...
>
> OK, that's a fairly convincing argument. Fire away.
>
> (I'm still not sure you found all the relevant places in the
> documentation, however.)
Here's a new patch + file. This one allows ALTER [SEQUENCE | VIEW] to
work only on the respective database objects, but permits the old
ALTER TABLE syntax.
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
Attachments:
alter_view_sequence_v2.diff (text/plain, 10.7K) download
Index: doc/src/sgml/reference.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/reference.sgml,v
retrieving revision 1.63
diff -c -r1.63 reference.sgml
*** doc/src/sgml/reference.sgml 26 Apr 2007 16:13:08 -0000 1.63
--- doc/src/sgml/reference.sgml 1 Jul 2007 19:42:33 -0000
***************
*** 53,58 ****
--- 53,59 ----
&alterTrigger;
&alterType;
&alterUser;
+ &alterView;
&analyze;
&begin;
&checkpoint;
Index: doc/src/sgml/ref/allfiles.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/allfiles.sgml,v
retrieving revision 1.70
diff -c -r1.70 allfiles.sgml
*** doc/src/sgml/ref/allfiles.sgml 26 Apr 2007 16:13:08 -0000 1.70
--- doc/src/sgml/ref/allfiles.sgml 1 Jul 2007 19:42:33 -0000
***************
*** 25,30 ****
--- 25,31 ----
<!entity alterTrigger system "alter_trigger.sgml">
<!entity alterType system "alter_type.sgml">
<!entity alterUser system "alter_user.sgml">
+ <!entity alterView system "alter_view.sgml">
<!entity analyze system "analyze.sgml">
<!entity begin system "begin.sgml">
<!entity checkpoint system "checkpoint.sgml">
Index: doc/src/sgml/ref/alter_sequence.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/alter_sequence.sgml,v
retrieving revision 1.16
diff -c -r1.16 alter_sequence.sgml
*** doc/src/sgml/ref/alter_sequence.sgml 31 Jan 2007 23:26:02 -0000 1.16
--- doc/src/sgml/ref/alter_sequence.sgml 1 Jul 2007 19:42:34 -0000
***************
*** 29,34 ****
--- 29,35 ----
[ RESTART [ WITH ] <replaceable class="parameter">start</replaceable> ] [ CACHE <replaceable class="parameter">cache</replaceable> ] [ [ NO ] CYCLE ]
[ OWNED BY { <replaceable class="parameter">table</replaceable>.<replaceable class="parameter">column</replaceable> | NONE } ]
ALTER SEQUENCE <replaceable class="parameter">name</replaceable> SET SCHEMA <replaceable class="parameter">new_schema</replaceable>
+ ALTER SEQUENCE <replaceable class="parameter">name</replaceable> RENAME TO <replaceable class="parameter">new_name</replaceable>
</synopsis>
</refsynopsisdiv>
***************
*** 190,195 ****
--- 191,207 ----
</para>
</listitem>
</varlistentry>
+
+ <varlistentry>
+ <term><literal>RENAME TO</literal> <replaceable class="parameter">new_name</replaceable></term>
+ <listitem>
+ <para>
+ The <literal>RENAME TO</literal> option causes the sequence to be
+ renamed.
+ </para>
+ </listitem>
+ </varlistentry>
+
</variablelist>
</para>
</refsect1>
Index: src/backend/commands/alter.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/commands/alter.c,v
retrieving revision 1.23
diff -c -r1.23 alter.c
*** src/backend/commands/alter.c 26 Mar 2007 16:58:38 -0000 1.23
--- src/backend/commands/alter.c 1 Jul 2007 19:42:34 -0000
***************
*** 83,88 ****
--- 83,90 ----
break;
case OBJECT_TABLE:
+ case OBJECT_SEQUENCE:
+ case OBJECT_VIEW:
case OBJECT_INDEX:
case OBJECT_COLUMN:
case OBJECT_TRIGGER:
***************
*** 96,101 ****
--- 98,105 ----
switch (stmt->renameType)
{
case OBJECT_TABLE:
+ case OBJECT_SEQUENCE:
+ case OBJECT_VIEW:
case OBJECT_INDEX:
{
/*
***************
*** 113,119 ****
aclcheck_error(aclresult, ACL_KIND_NAMESPACE,
get_namespace_name(namespaceId));
! renamerel(relid, stmt->newname);
break;
}
case OBJECT_COLUMN:
--- 117,123 ----
aclcheck_error(aclresult, ACL_KIND_NAMESPACE,
get_namespace_name(namespaceId));
! renamerel(relid, stmt->newname, stmt->renameType);
break;
}
case OBJECT_COLUMN:
Index: src/backend/commands/tablecmds.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/commands/tablecmds.c,v
retrieving revision 1.228
diff -c -r1.228 tablecmds.c
*** src/backend/commands/tablecmds.c 23 Jun 2007 22:12:50 -0000 1.228
--- src/backend/commands/tablecmds.c 1 Jul 2007 19:42:35 -0000
***************
*** 41,46 ****
--- 41,47 ----
#include "executor/executor.h"
#include "miscadmin.h"
#include "nodes/makefuncs.h"
+ #include "nodes/parsenodes.h"
#include "optimizer/clauses.h"
#include "optimizer/plancat.h"
#include "optimizer/prep.h"
***************
*** 1621,1627 ****
* sequence, AFAIK there's no need for it to be there.
*/
void
! renamerel(Oid myrelid, const char *newrelname)
{
Relation targetrelation;
Relation relrelation; /* for RELATION relation */
--- 1622,1628 ----
* sequence, AFAIK there's no need for it to be there.
*/
void
! renamerel(Oid myrelid, const char *newrelname, ObjectType newreltype)
{
Relation targetrelation;
Relation relrelation; /* for RELATION relation */
***************
*** 1633,1640 ****
bool relhastriggers;
/*
! * Grab an exclusive lock on the target table or index, which we will NOT
! * release until end of transaction.
*/
targetrelation = relation_open(myrelid, AccessExclusiveLock);
--- 1634,1641 ----
bool relhastriggers;
/*
! * Grab an exclusive lock on the target table, index, sequence or
! * view, which we will NOT release until end of transaction.
*/
targetrelation = relation_open(myrelid, AccessExclusiveLock);
***************
*** 1648,1653 ****
--- 1649,1662 ----
RelationGetRelationName(targetrelation))));
relkind = targetrelation->rd_rel->relkind;
+ if (newreltype == OBJECT_SEQUENCE && relkind != 'S')
+ ereport(ERROR,
+ (errcode(ERRCODE_WRONG_OBJECT_TYPE),
+ errmsg("You can only call ALTER SEQUENCE on a sequence")));
+ if (newreltype == OBJECT_VIEW && relkind != 'v')
+ ereport(ERROR,
+ (errcode(ERRCODE_WRONG_OBJECT_TYPE),
+ errmsg("You can only call ALTER VIEW on a view")));
relhastriggers = (targetrelation->rd_rel->reltriggers > 0);
/*
Index: src/backend/parser/gram.y
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/parser/gram.y,v
retrieving revision 2.596
diff -c -r2.596 gram.y
*** src/backend/parser/gram.y 23 Jun 2007 22:12:51 -0000 2.596
--- src/backend/parser/gram.y 1 Jul 2007 19:42:36 -0000
***************
*** 4546,4551 ****
--- 4546,4569 ----
n->newname = $6;
$$ = (Node *)n;
}
+ | ALTER SEQUENCE relation_expr RENAME TO name
+ {
+ RenameStmt *n = makeNode(RenameStmt);
+ n->renameType = OBJECT_SEQUENCE;
+ n->relation = $3;
+ n->subname = NULL;
+ n->newname = $6;
+ $$ = (Node *)n;
+ }
+ | ALTER VIEW relation_expr RENAME TO name
+ {
+ RenameStmt *n = makeNode(RenameStmt);
+ n->renameType = OBJECT_VIEW;
+ n->relation = $3;
+ n->subname = NULL;
+ n->newname = $6;
+ $$ = (Node *)n;
+ }
| ALTER INDEX relation_expr RENAME TO name
{
RenameStmt *n = makeNode(RenameStmt);
Index: src/backend/tcop/utility.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/tcop/utility.c,v
retrieving revision 1.282
diff -c -r1.282 utility.c
*** src/backend/tcop/utility.c 28 Jun 2007 00:02:39 -0000 1.282
--- src/backend/tcop/utility.c 1 Jul 2007 19:42:37 -0000
***************
*** 1574,1579 ****
--- 1574,1582 ----
case OBJECT_SCHEMA:
tag = "ALTER SCHEMA";
break;
+ case OBJECT_SEQUENCE:
+ tag = "ALTER SEQUENCE";
+ break;
case OBJECT_COLUMN:
case OBJECT_TABLE:
tag = "ALTER TABLE";
***************
*** 1584,1589 ****
--- 1587,1595 ----
case OBJECT_TRIGGER:
tag = "ALTER TRIGGER";
break;
+ case OBJECT_VIEW:
+ tag = "ALTER VIEW";
+ break;
default:
tag = "???";
break;
Index: src/bin/psql/tab-complete.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/bin/psql/tab-complete.c,v
retrieving revision 1.165
diff -c -r1.165 tab-complete.c
*** src/bin/psql/tab-complete.c 13 Jun 2007 23:59:47 -0000 1.165
--- src/bin/psql/tab-complete.c 1 Jul 2007 19:42:37 -0000
***************
*** 602,608 ****
static const char *const list_ALTER[] =
{"AGGREGATE", "CONVERSION", "DATABASE", "DOMAIN", "FUNCTION",
"GROUP", "INDEX", "LANGUAGE", "OPERATOR", "ROLE", "SCHEMA", "SEQUENCE", "TABLE",
! "TABLESPACE", "TRIGGER", "TYPE", "USER", NULL};
COMPLETE_WITH_LIST(list_ALTER);
}
--- 602,608 ----
static const char *const list_ALTER[] =
{"AGGREGATE", "CONVERSION", "DATABASE", "DOMAIN", "FUNCTION",
"GROUP", "INDEX", "LANGUAGE", "OPERATOR", "ROLE", "SCHEMA", "SEQUENCE", "TABLE",
! "TABLESPACE", "TRIGGER", "TYPE", "USER", "VIEW", NULL};
COMPLETE_WITH_LIST(list_ALTER);
}
***************
*** 714,720 ****
{
static const char *const list_ALTERSEQUENCE[] =
{"INCREMENT", "MINVALUE", "MAXVALUE", "RESTART", "NO", "CACHE", "CYCLE",
! "SET SCHEMA", NULL};
COMPLETE_WITH_LIST(list_ALTERSEQUENCE);
}
--- 714,720 ----
{
static const char *const list_ALTERSEQUENCE[] =
{"INCREMENT", "MINVALUE", "MAXVALUE", "RESTART", "NO", "CACHE", "CYCLE",
! "SET SCHEMA", "RENAME TO", NULL};
COMPLETE_WITH_LIST(list_ALTERSEQUENCE);
}
***************
*** 728,733 ****
--- 728,742 ----
COMPLETE_WITH_LIST(list_ALTERSEQUENCE2);
}
+ /* ALTER VIEW <name> */
+ else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
+ pg_strcasecmp(prev2_wd, "VIEW") == 0)
+ {
+ static const char *const list_ALTERVIEW[] =
+ {"RENAME TO"};
+
+ COMPLETE_WITH_LIST(list_ALTERVIEW);
+ }
/* ALTER TRIGGER <name>, add ON */
else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
pg_strcasecmp(prev2_wd, "TRIGGER") == 0)
Index: src/include/commands/tablecmds.h
===================================================================
RCS file: /projects/cvsroot/pgsql/src/include/commands/tablecmds.h,v
retrieving revision 1.33
diff -c -r1.33 tablecmds.h
*** src/include/commands/tablecmds.h 11 May 2007 20:17:10 -0000 1.33
--- src/include/commands/tablecmds.h 1 Jul 2007 19:42:37 -0000
***************
*** 43,49 ****
bool recursing);
extern void renamerel(Oid myrelid,
! const char *newrelname);
extern void find_composite_type_dependencies(Oid typeOid,
const char *origTblName,
--- 43,50 ----
bool recursing);
extern void renamerel(Oid myrelid,
! const char *newrelname,
! ObjectType newreltype);
extern void find_composite_type_dependencies(Oid typeOid,
const char *origTblName,
alter_view.sgml (text/sgml, 2.3K) download
<!--
$PostgreSQL: pgsql/doc/src/sgml/ref/alter_view.sgml,v 1.0 Fri Jun 29 2007 fetter Exp $
PostgreSQL documentation
-->
<refentry id="SQL-ALTERVIEW">
<refmeta>
<refentrytitle id="SQL-ALTERVIEW-TITLE">ALTER VIEW</refentrytitle>
<refmiscinfo>SQL - Language Statements</refmiscinfo>
</refmeta>
<refnamediv>
<refname>ALTER VIEW</refname>
<refpurpose>change a view</refpurpose>
</refnamediv>
<indexterm zone="sql-alterview">
<primary>ALTER VIEW</primary>
</indexterm>
<refsynopsisdiv>
<synopsis>
ALTER VIEW <replaceable>name</replaceable> RENAME TO <replaceable>newname</replaceable>
</synopsis>
</refsynopsisdiv>
<refsect1>
<title>Description</title>
<para>
<command>ALTER VIEW</command> changes the definition of a
view.
</para>
<para>
You must own the view to use <command>ALTER VIEW</>.
To alter the owner, you must also be a direct or indirect member of the new
owning role, and that role must have <literal>CREATE</literal> privilege on
the view's schema. (These restrictions enforce that altering the
owner doesn't do anything you couldn't do by dropping and recreating the
view. However, a superuser can alter ownership of any view
anyway.)
</para>
</refsect1>
<refsect1>
<title>Parameters</title>
<variablelist>
<varlistentry>
<term><replaceable class="parameter">name</replaceable></term>
<listitem>
<para>
The name (optionally schema-qualified) of an existing view.
</para>
</listitem>
</varlistentry>
<varlistentry>
<term><replaceable class="parameter">newname</replaceable></term>
<listitem>
<para>
The new name of the view.
</para>
</listitem>
</varlistentry>
</variablelist>
</refsect1>
<refsect1>
<title>Examples</title>
<para>
To rename the view <literal>foo</literal> to
<literal>bar</literal>:
<programlisting>
ALTER VIEW foo RENAME TO bar;
</programlisting>
</para>
<refsect1>
<title>Compatibility</title>
<para>
There is no <command>ALTER VIEW</command> statement in the SQL
standard.
</para>
</refsect1>
<refsect1>
<title>See Also</title>
<simplelist type="inline">
<member><xref linkend="sql-createview" endterm="sql-createview-title"></member>
<member><xref linkend="sql-dropview" endterm="sql-dropview-title"></member>
</simplelist>
</refsect1>
</refentry>
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
@ 2007-07-02 04:03 ` Neil Conway <neilc@samurai.com>
2007-07-02 07:33 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
1 sibling, 1 reply; 22+ messages in thread
From: Neil Conway @ 2007-07-02 04:03 UTC (permalink / raw)
To: David Fetter <david@fetter.org>; +Cc: PostgreSQL Patches <pgsql-patches@postgresql.org>; Tom Lane <tgl@sss.pgh.pa.us>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
On Sun, 2007-01-07 at 12:55 -0700, David Fetter wrote:
> Here's a new patch + file. This one allows ALTER [SEQUENCE | VIEW] to
> work only on the respective database objects, but permits the old
> ALTER TABLE syntax.
How about taking a look at the more thorough documentation updates Tom
suggested?
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
2007-07-02 04:03 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
@ 2007-07-02 07:33 ` David Fetter <david@fetter.org>
0 siblings, 0 replies; 22+ messages in thread
From: David Fetter @ 2007-07-02 07:33 UTC (permalink / raw)
To: Neil Conway <neilc@samurai.com>; +Cc: PostgreSQL Patches <pgsql-patches@postgresql.org>; Tom Lane <tgl@sss.pgh.pa.us>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
On Sun, Jul 01, 2007 at 09:03:45PM -0700, Neil Conway wrote:
> On Sun, 2007-01-07 at 12:55 -0700, David Fetter wrote:
> > Here's a new patch + file. This one allows ALTER [SEQUENCE | VIEW] to
> > work only on the respective database objects, but permits the old
> > ALTER TABLE syntax.
>
> How about taking a look at the more thorough documentation updates Tom
> suggested?
So far I've documented it in the index, the references, and in psql's
tab completion. What other places would you suggest I look?
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter
Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
@ 2007-07-03 01:34 ` Neil Conway <neilc@samurai.com>
2007-07-03 03:13 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 22+ messages in thread
From: Neil Conway @ 2007-07-03 01:34 UTC (permalink / raw)
To: David Fetter <david@fetter.org>; +Cc: PostgreSQL Patches <pgsql-patches@postgresql.org>; Tom Lane <tgl@sss.pgh.pa.us>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
On Sun, 2007-07-01 at 12:55 -0700, David Fetter wrote:
> Here's a new patch + file. This one allows ALTER [SEQUENCE | VIEW] to
> work only on the respective database objects, but permits the old
> ALTER TABLE syntax.
Applied with some fixes. Thanks for the patch. ALTER VIEW ... SET SCHEMA
might be another worthwhile thing to add, for consistency.
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
2007-07-03 01:34 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
@ 2007-07-03 03:13 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 05:50 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
0 siblings, 1 reply; 22+ messages in thread
From: Tom Lane @ 2007-07-03 03:13 UTC (permalink / raw)
To: Neil Conway <neilc@samurai.com>; +Cc: David Fetter <david@fetter.org>; PostgreSQL Patches <pgsql-patches@postgresql.org>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
Neil Conway <neilc@samurai.com> writes:
> On Sun, 2007-07-01 at 12:55 -0700, David Fetter wrote:
>> Here's a new patch + file. This one allows ALTER [SEQUENCE | VIEW] to
>> work only on the respective database objects, but permits the old
>> ALTER TABLE syntax.
> Applied with some fixes. Thanks for the patch. ALTER VIEW ... SET SCHEMA
> might be another worthwhile thing to add, for consistency.
Er, was this on the agenda for 8.3?
regards, tom lane
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
2007-07-03 01:34 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 03:13 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-07-03 05:50 ` Neil Conway <neilc@samurai.com>
2007-07-03 06:38 ` Re: [DOCS] rename of a view Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
0 siblings, 1 reply; 22+ messages in thread
From: Neil Conway @ 2007-07-03 05:50 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: David Fetter <david@fetter.org>; PostgreSQL Patches <pgsql-patches@postgresql.org>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
On Mon, 2007-02-07 at 23:13 -0400, Tom Lane wrote:
> Er, was this on the agenda for 8.3?
Well, it seemed fairly harmless to me (no behavioral changes and very
little new code, just syntax), so I didn't see a compelling reason to
delay applying it for a few months. But I can revert it if you'd prefer.
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
2007-07-03 01:34 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 03:13 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 05:50 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
@ 2007-07-03 06:38 ` Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
2007-07-03 13:56 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 22+ messages in thread
From: Stefan Kaltenbrunner @ 2007-07-03 06:38 UTC (permalink / raw)
To: Neil Conway <neilc@samurai.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; David Fetter <david@fetter.org>; PostgreSQL Patches <pgsql-patches@postgresql.org>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
Neil Conway wrote:
> On Mon, 2007-02-07 at 23:13 -0400, Tom Lane wrote:
>> Er, was this on the agenda for 8.3?
>
> Well, it seemed fairly harmless to me (no behavioral changes and very
> little new code, just syntax), so I didn't see a compelling reason to
> delay applying it for a few months. But I can revert it if you'd prefer.
hmm so now we have ALTER VIEW/SEQUENCE commands that can do a bit but
not all of what ALTER TABLE can do (renaming columns of a VIEW or
changing the owner for example).
I agree in principle that having those functionality in ALTER
VIEW/SEQUENCE is a good idea but only bringing in a bit of the required
functionality which still does not solve the "uhm why do I need ALTER
TABLE to manipulate a VIEW" months after the feature freeze sounds a bit
wrong to me :-(
Stefan
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
2007-07-03 01:34 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 03:13 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 05:50 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 06:38 ` Re: [DOCS] rename of a view Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
@ 2007-07-03 13:56 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 23:32 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
0 siblings, 1 reply; 22+ messages in thread
From: Tom Lane @ 2007-07-03 13:56 UTC (permalink / raw)
To: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>; +Cc: Neil Conway <neilc@samurai.com>; David Fetter <david@fetter.org>; PostgreSQL Patches <pgsql-patches@postgresql.org>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
Stefan Kaltenbrunner <stefan@kaltenbrunner.cc> writes:
> Neil Conway wrote:
>> On Mon, 2007-02-07 at 23:13 -0400, Tom Lane wrote:
>>> Er, was this on the agenda for 8.3?
>>
>> Well, it seemed fairly harmless to me (no behavioral changes and very
>> little new code, just syntax), so I didn't see a compelling reason to
>> delay applying it for a few months. But I can revert it if you'd prefer.
> hmm so now we have ALTER VIEW/SEQUENCE commands that can do a bit but
> not all of what ALTER TABLE can do (renaming columns of a VIEW or
> changing the owner for example).
> I agree in principle that having those functionality in ALTER
> VIEW/SEQUENCE is a good idea but only bringing in a bit of the required
> functionality which still does not solve the "uhm why do I need ALTER
> TABLE to manipulate a VIEW" months after the feature freeze sounds a bit
> wrong to me :-(
What's bothering me here is failure to focus. We are not in development
mode today, and have not been for months. What we need to be doing is
wrapping up the patches that are already on the to-do list, not
expending developer effort on new stuff. Neil, according to
http://developer.postgresql.org/index.php/Todo:PatchStatus
you have accepted two patches to review --- what is happening with
those?
regards, tom lane
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: [DOCS] rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 00:16 ` Re: rename of a view David Fetter <david@fetter.org>
2007-06-30 04:15 ` Re: rename of a view Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:43 ` Re: rename of a view Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Re: rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` Re: [DOCS] rename of a view David Fetter <david@fetter.org>
2007-07-03 01:34 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 03:13 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 05:50 ` Re: [DOCS] rename of a view Neil Conway <neilc@samurai.com>
2007-07-03 06:38 ` Re: [DOCS] rename of a view Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
2007-07-03 13:56 ` Re: [DOCS] rename of a view Tom Lane <tgl@sss.pgh.pa.us>
@ 2007-07-03 23:32 ` Neil Conway <neilc@samurai.com>
0 siblings, 0 replies; 22+ messages in thread
From: Neil Conway @ 2007-07-03 23:32 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>; David Fetter <david@fetter.org>; PostgreSQL Patches <pgsql-patches@postgresql.org>; Euler Taveira de Oliveira <euler@timbira.com>; Susanne Ebrecht <miracee@miracee.de>
On Tue, 2007-07-03 at 09:56 -0400, Tom Lane wrote:
> Neil, according to
> http://developer.postgresql.org/index.php/Todo:PatchStatus
> you have accepted two patches to review --- what is happening with
> those?
Yeah, sorry, forgot about those -- I'll take a look at them tonight.
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
@ 2007-06-28 15:27 ` Neil Conway <neilc@samurai.com>
2007-06-29 18:32 ` Re: rename of a view Susanne Ebrecht <miracee@miracee.de>
1 sibling, 1 reply; 22+ messages in thread
From: Neil Conway @ 2007-06-28 15:27 UTC (permalink / raw)
To: Susanne Ebrecht <miracee@miracee.de>; +Cc: pgsql-docs
On Thu, 2007-28-06 at 13:31 +0200, Susanne Ebrecht wrote:
> Than I just tried: alter table pgview rename to bettername;
>
> that works, but there is no hint at the documentation, that you can
> rename a view via alter table.
From the ALTER TABLE reference page: "The RENAME forms change the name
of a table (or an index, sequence, or view) or the name of an individual
column in a table."
Of course, it could be made more obvious...
-Neil
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: rename of a view
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 15:27 ` Re: rename of a view Neil Conway <neilc@samurai.com>
@ 2007-06-29 18:32 ` Susanne Ebrecht <miracee@miracee.de>
0 siblings, 0 replies; 22+ messages in thread
From: Susanne Ebrecht @ 2007-06-29 18:32 UTC (permalink / raw)
To: Neil Conway <neilc@samurai.com>; +Cc: pgsql-docs
Neil Conway wrote:
> On Thu, 2007-28-06 at 13:31 +0200, Susanne Ebrecht wrote:
>
>> Than I just tried: alter table pgview rename to bettername;
>>
>> that works, but there is no hint at the documentation, that you can
>> rename a view via alter table.
>>
>
> >From the ALTER TABLE reference page: "The RENAME forms change the name
> of a table (or an index, sequence, or view) or the name of an individual
> column in a table."
>
> Of course, it could be made more obvious...
>
I looked at \h ALTER TABLE
my system is in German, and there is no hint, that this is for views too.
Using 8.2.4.
Susanne
--
Susanne Ebrecht,
52066 Aachen, Germany
^ permalink raw reply [nested|flat] 22+ messages in thread
end of thread, other threads:[~2007-07-03 23:32 UTC | newest]
Thread overview: 22+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2007-06-28 11:31 rename of a view Susanne Ebrecht <miracee@miracee.de>
2007-06-28 14:16 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-06-29 18:32 ` David Fetter <david@fetter.org>
2007-06-30 00:16 ` David Fetter <david@fetter.org>
2007-06-30 04:15 ` Euler Taveira de Oliveira <euler@timbira.com>
2007-06-30 04:26 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:33 ` Neil Conway <neilc@samurai.com>
2007-06-30 05:36 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-06-30 05:40 ` David Fetter <david@fetter.org>
2007-06-30 05:43 ` Neil Conway <neilc@samurai.com>
2007-06-30 05:48 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-07-01 19:55 ` David Fetter <david@fetter.org>
2007-07-02 04:03 ` Neil Conway <neilc@samurai.com>
2007-07-02 07:33 ` David Fetter <david@fetter.org>
2007-07-03 01:34 ` Neil Conway <neilc@samurai.com>
2007-07-03 03:13 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 05:50 ` Neil Conway <neilc@samurai.com>
2007-07-03 06:38 ` Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
2007-07-03 13:56 ` Tom Lane <tgl@sss.pgh.pa.us>
2007-07-03 23:32 ` Neil Conway <neilc@samurai.com>
2007-06-28 15:27 ` Neil Conway <neilc@samurai.com>
2007-06-29 18:32 ` Susanne Ebrecht <miracee@miracee.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox