From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ian Barwick <ian@2ndquadrant.com>
cc: pgsql-docs@postgresql.org
Subject: Re: Minor doc correction for SPI_execute_with_args
In-reply-to: <55681CBD.8040004@2ndquadrant.com>
References: <55681CBD.8040004@2ndquadrant.com>
Comments: In-reply-to Ian Barwick <ian@2ndquadrant.com>
 message dated "Fri, 29 May 2015 17:01:01 +0900"
Date: Sat, 30 May 2015 13:57:29 -0400
Message-ID: <27750.1433008649@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

Ian Barwick <ian@2ndquadrant.com> writes:
> The documentation for SPI_execute_with_args:
>   http://www.postgresql.org/docs/current/static/spi-spi-execute-with-args.html
> claims it returns the same value as SPI_execute, whereas it actually
> calls SPI_execute_plan which can produce two additional error codes.

But SPI_execute also calls _SPI_execute_plan.  Moreover, the documented
reasons for SPI_execute_plan to return additional error codes don't match
up too closely with SPI_execute_with_args (eg, there's no "plan"
argument, so saying "plan was prepared with some parameters" is pretty
meaningless here).

If what you're looking at is the extra error conditions right at the start
of SPI_execute_with_args, my inclination would be to document them without
any reference to SPI_execute_plan, ie we'd add text much like what's
under SPI_execute_plan but with the descriptions of the error codes
adjusted to agree with this function.

			regards, tom lane


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs