Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 886F41337B4E for ; Wed, 13 Apr 2011 04:00:14 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 27842-05 for ; Wed, 13 Apr 2011 07:00:05 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 91D071337B67 for ; Wed, 13 Apr 2011 04:00:05 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p3D7031X027762; Wed, 13 Apr 2011 03:00:03 -0400 (EDT) To: Josh Kupershmidt cc: pgsql-docs Subject: Re: CREATE EXTENSION: documenting prereqs In-reply-to: References: Comments: In-reply-to Josh Kupershmidt message dated "Tue, 12 Apr 2011 18:52:12 -0400" Date: Wed, 13 Apr 2011 03:00:03 -0400 Message-ID: <27761.1302678003@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201104/66 X-Sequence-Number: 6637 Josh Kupershmidt writes: > Well, obviously I need to go into ./contrib/hstore/ and run make && > make install (or install the appropriate -contrib package if I were > using a packaged build of Postgres). I think it'd be nice to give > users some hint about this prerequisite. Appendix F [1] discusses > this, but there's currently no link from [2] to [1]. The way the > CREATE EXTENSION page reads right now, I could forgive a new user > thinking he shouldn't need to install any dependencies. On reflection there are a couple other cross-references that would be useful here, too. I've committed a modified version of this. > A complementary approach would be to add an errhint to the "could not > open extension control file..." error suggesting that the user install > the contrib package himself, though I'm not sure offhand about the > wording, especially since a user might be trying to install > who-knows-what extension. Yeah, I'm not sure how to do anything useful in one-or-so-lines there. regards, tom lane